From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25200 invoked from network); 25 Apr 2002 07:31:22 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 25 Apr 2002 07:31:22 -0000 Received: (qmail 6844 invoked by alias); 25 Apr 2002 07:31:15 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 17035 Received: (qmail 6833 invoked from network); 25 Apr 2002 07:31:14 -0000 From: Sven Wischnowsky MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15559.45206.899431.496885@wischnow.berkom.de> Date: Thu, 25 Apr 2002 09:30:30 +0200 To: zsh-workers@sunsite.dk Subject: Re: new valgrind errors In-Reply-To: <20020425053552.11174.qmail@web10405.mail.yahoo.com> References: <20020425053552.11174.qmail@web10405.mail.yahoo.com> X-Mailer: VM 6.95 under 21.5 (patch 3) "asparagus" XEmacs Lucid Felix Rosencrantz wrote: > Here is condensed output based on the latest changes. -FR. > ERROR SUMMARY: 1537 errors from 12 contexts (suppressed: 24 from 1) > > 11 errors in context 1 of 12: > Invalid read of size 4 > at 0x80A49C3: pattryrefs (pattern.c:1357) > by 0x80A4952: pattry (pattern.c:1331) > by 0x413B1E39: lookupstyle (zutil.c:247) > by 0x413B27C4: bin_zstyle (zutil.c:439) > Address 0x4105951C is 20 bytes inside a block of size 80 free'd > at 0x40040311: free (vg_clientfuncs.c:156) > by 0x808C737: zfree (mem.c:1391) > by 0x80A7229: freepatprog (pattern.c:2326) > by 0x413B1912: setstypat (zutil.c:135) Argh. That part of the patch was a thinko. Re-fix below. But then I don't see how the original error came to pass. Bye Sven Index: Src/Modules/zutil.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Modules/zutil.c,v retrieving revision 1.10 diff -u -r1.10 zutil.c --- Src/Modules/zutil.c 24 Apr 2002 07:59:19 -0000 1.10 +++ Src/Modules/zutil.c 25 Apr 2002 07:29:24 -0000 @@ -132,7 +132,6 @@ freearray(p->vals); if (p->eval) freeeprog(p->eval); - freepatprog(p->prog); p->vals = zarrdup(vals); p->eval = eprog; -- Sven Wischnowsky wischnow@berkom.de