From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 8fc9bf36 for ; Mon, 13 May 2019 08:48:05 +0000 (UTC) Received: (qmail 24836 invoked by alias); 13 May 2019 08:47:48 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44287 Received: (qmail 14987 invoked by uid 1010); 13 May 2019 08:47:48 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25447. spamassassin: 3.4.2. Clear:RC:0(210.118.77.11):SA:0(-7.0/5.0):. Processed in 2.743591 secs); 13 May 2019 08:47:48 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.11 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190513084708euoutp016d19bfb049551d771f5aec10b93094d3~eMcGrNHH70822508225euoutp01i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1557737229; bh=R/FeJRcX9BuD9b2qDuK43ISDRl6z+Fv8Kgs7dqESRsw=; h=Subject:From:To:Date:In-Reply-To:References:From; b=ul491nynnfhMvis9ZNKzwHYblCbrzf4IsdLHBIHxJH6KqdvH7r7tjumBsuufwz1z/ prcVNPdXG9OYBRIZstsglpEUpSYXX2py3UmbCyg2n9pvSVDrS3VwyEAUcOVkABSzzz IQ+yDBWS8eannGlGiBZKmmWBHESg/H8TZav+2u0M= X-AuditID: cbfec7f5-fbbf09c0000010e5-e6-5cd92f0c0551 Message-ID: <1557737226.5779.5.camel@samsung.com> Subject: Re: missing braces or wrong indent? From: Peter Stephenson To: Date: Mon, 13 May 2019 09:47:06 +0100 In-Reply-To: X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djP87o8+jdjDDZO5bE42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGUf+nGEpuMNR8WHiS9YGxm72LkYODgkBE4m5zyO6GLk4hARW MEosPvaIqYuRE8jpY5K4doAFItHLJLHqwSl2kARIw/2Gn1CJ5YwSXVtaWeGqFi/+zAThnGGU uLJ2GyOEc4FRovfbX7B+XgFDidc3/rOB2MICOhK9M5eBxdmA4lM3zWYEsUUEJCWuNZ8Gs1kE VCVWvpoMVsMpECjxb9caqDs0JDbcPMYEMVNQ4uTMJywgNrOAvETz1tnMIIslBG6zSbw+f4YV osFF4uC8T8wQtrDEq+NboAbJSPzfOZ8JoqGdUWLNpNfsEE4Po8Smo3cYIaqsJfpuX2QEhRmz gKbE+l36EGFHiXMbnjBCgpJP4sZbQYgj+CQmbZvODBHmlehoE4KoVpPY0bQVqlpG4ukahQmM SrOQfDALyQezEFYtYGRexSieWlqcm55abJyXWq5XnJhbXJqXrpecn7uJEZgKTv87/nUH474/ SYcYBTgYlXh4BZ7fiBFiTSwrrsw9xCjBwawkwhulCBTiTUmsrEotyo8vKs1JLT7EKM3BoiTO W83wIFpIID2xJDU7NbUgtQgmy8TBKdXAWBed6S2t8SJxgfns7V3hp4SyfE3Fr69rOqWTaHZ/ 347rjBM4JFf42boaHFsv0uqy7vv/l4nJxq+3PmqYUqz5bIX6l2dXDqz5/v+3qePfz+9t+ScJ ir4sV0o8r1i9f+vW/WsmlwlqawUniPo6sO2Y+nYR47TGfbNWPLPYW3lj0cuSyDknMiI/rldi Kc5INNRiLipOBADRuCxOAQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4XV1u/ZsxBs8PKVkcbH7I5MDoserg B6YAxig9m6L80pJUhYz84hJbpWhDCyM9Q0sLPSMTSz1DY/NYKyNTJX07m5TUnMyy1CJ9uwS9 jCN/zrAU3OGo+DDxJWsDYzd7FyMnh4SAicT9hp8sXYxcHEICSxklXl28xwKRkJH4dOUjVJGw xJ9rXWwQRd1MEg3XdjCCJIQEzjBK3FtWCJG4wCjRvPQiE0iCV8BQ4vWN/2wgtrCAjkTvzGVg k9iA4lM3zQZrFhGQlLjWfBrMZhFQlVj5ajJYDadAoMS/XWvY4U5aP7cHrIhZQFOidftvqJM0 JDbcPAa1TFDi5MwnLBA18hLNW2czT2AUmoWkZRaSsllIyhYwMq9iFEktLc5Nzy020itOzC0u zUvXS87P3cQIDP9tx35uAfr0XfAhRgEORiUeXoHnN2KEWBPLiitzDzFKcDArifBGKQKFeFMS K6tSi/Lji0pzUosPMZoCfTSRWUo0OR8Ym3kl8YamhuYWlobmxubGZhZK4rwdAgdjhATSE0tS s1NTC1KLYPqYODilGhg5Jih+cD3Ye/XGMZuP13V6U4RmyS28ctW8VvaPrm7TmyXFXeHsSeeO zT8kNVH98JeoCTsUeNbISwndNZ6l8WSFwivfXAYejUeNMxu1fhsHSy3WXfr0xTSNr2c0OZLU Fv19a84qqRWiabgrecGazIVx0SJ37j3Yoblx61s/a/d/Vy60WZmuOf9LiaU4I9FQi7moOBEA MRs7QZUCAAA= X-CMS-MailID: 20190513084707eucas1p14542c82744cc1add0b4b7ff2b5ab3be4 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190511180553epcas2p2115461224eb064782dcff498f1b57b74 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190511180553epcas2p2115461224eb064782dcff498f1b57b74 References: On Sat, 2019-05-11 at 20:04 +0200, Mikael Magnusson wrote: > Just submitted a new coverity build and looked at some stuff it was > unhappy about; this isn't one of them but what is going on here? >  > clone.c::bin_clone > 55 >     if (!pid) { >  clearjobtab(0); >  ppid = getppid(); >  mypid = getpid(); > #ifdef HAVE_SETSID >  if (setsid() != mypid) >      zwarnnam(nam, "failed to create new session: %e", errno); > #elif defined(TIOCNOTTY) >      if (ioctl(SHTTY, TIOCNOTTY, 0)) >      zwarnnam(*args, "%e", errno); >      setpgrp(0L, mypid); > #endif >  dup2(ttyfd,0); > > This/these if statements look completely bogusly indented, but maybe > it's also missing braces? I can't tell because I have no idea what it > wants to accomplish. I'd guess just the indentation; I can't see why the setpgrp() would be particularly useful on failure.  Alternatively, possibly there could even be an "else" before the setpgrp()?  Presumably this is rarely compiled and even then the ioctl() doesn't usually fail so very hard to see the effect of. pws