From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 6ade9f8c for ; Mon, 13 May 2019 09:02:12 +0000 (UTC) Received: (qmail 17010 invoked by alias); 13 May 2019 09:02:00 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44288 Received: (qmail 19313 invoked by uid 1010); 13 May 2019 09:02:00 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25447. spamassassin: 3.4.2. Clear:RC:0(210.118.77.12):SA:0(-7.0/5.0):. Processed in 1.565016 secs); 13 May 2019 09:02:00 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.12 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190513090124euoutp02018bf08ceb9c34de8f8935f02b67686e~eMojR27yS0323103231euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1557738084; bh=41h+fcBDGMcEpdQp27kcqR2kJLByzs30U8Cx8iuwxxs=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Hv86wOt++5qCk2uF/ORVOYczXP3FGjW/80kHBbWG2Sqh3fQEYuNmDZ1bWTTbSn3I1 l1avd04EqK+6CifK2Ji0RUa+QQHsTq6XEkfYjSoUiYnJy767iO0RzKCDVFcNYA3K0z FxmB1gjgsS1b9bzwilTRtME/hYoFcKeT/ID+DzCA= X-AuditID: cbfec7f2-f2dff700000010ca-66-5cd93263b684 Message-ID: <1557738081.5779.6.camel@samsung.com> Subject: Re: #7 (typeset -Tp) (was Re: Zsh - Multiple DoS Vulnerabilities) From: Peter Stephenson To: Date: Mon, 13 May 2019 10:01:21 +0100 In-Reply-To: <58882-1557539125.040984@0wLk.G1UB.-8BX> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7djP87rJRjdjDKYsELc42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGa/WLGYquM1SMf91D2MD43XmLkZODgkBE4m/R5eydTFycQgJ rGCU+HxgDZTTxySx/P9NKKeXSeLynJ2sXYwcYC3npsdDxJczSty4vI4VZBRY0eJLehCJM4wS /1/eZYRwLjBKvPkwHaybV8BQ4vv5fJAGYQEviWeXT7KB2GxA4ambZjOC2CICkhLXmk+D2SwC qhINR7+B3copYCrRsfs6E8TdGhIbbh4Ds3kFBCVOznzCAmIzC8hLbH87hxlkr4TAczaJ84tP Qz3qIrFw0gMWCFtY4tXxLewQtozE6ck9LBAN7YwSaya9ZodwehglNh29wwhRZS3Rd/siI8gH zAKaEut36UOEHSWuPDzFDgkWPokbbwUhjuCTmLRtOjNEmFeio00IolpNYkfTVkaIsIzE0zUK ExiVZiH5YBaSD2YhrFrAyLyKUTy1tDg3PbXYMC+1XK84Mbe4NC9dLzk/dxMjMBGc/nf80w7G r5eSDjEKcDAq8fAKPL8RI8SaWFZcmXuIUYKDWUmEN0oRKMSbklhZlVqUH19UmpNafIhRmoNF SZy3muFBtJBAemJJanZqakFqEUyWiYNTqoGxMzSm+viEzODitlv7u+/8KL8gbX83v0/zs6n/ UrljHsvOFrz4tHdZyJnpJ7852FlP4b51rvqHRE9emcbOeyZMPR+K185NCfz8W/CvguFROUnu Y5ucZUSXpTz+y2mrb7pf9ew7zumJlip8LMuVf/6evXTjsZ+ORzdxaN+vtzCylCzn/nRjVtp0 JZbijERDLeai4kQAqD+nxQADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e/4Xd0ko5sxBrs+KVkcbH7I5MDoserg B6YAxig9m6L80pJUhYz84hJbpWhDCyM9Q0sLPSMTSz1DY/NYKyNTJX07m5TUnMyy1CJ9uwS9 jFdrFjMV3GapmP+6h7GB8TpzFyMHh4SAicS56fFdjFwcQgJLGSXW9F5l6WLkBIrLSHy68pEd whaW+HOtiw2iqJtJ4vSaFewQzhlGiScnZzJCOBcYJWY9mMYOMpZXwFDi+/l8kG5hAS+JZ5dP soHYbEDhqZtmM4LYIgKSEteaT4PZLAKqEg1HvzGD2JwCphIdu68zQcycySSx7OVPsJOYBTQl Wrf/hjpJQ2LDzWNMIDavgKDEyZlPoGrkJba/ncM8gVFoFpKWWUjKZiEpW8DIvIpRJLW0ODc9 t9hIrzgxt7g0L10vOT93EyMw+Lcd+7llB2PXu+BDjAIcjEo8vALPb8QIsSaWFVfmHmKU4GBW EuGNUgQK8aYkVlalFuXHF5XmpBYfYjQF+mgis5Rocj4wMvNK4g1NDc0tLA3Njc2NzSyUxHk7 BA7GCAmkJ5akZqemFqQWwfQxcXBKNTC63XMOY9TKPP1XiPnzSW2NkoBbRtpJs1cvY57zP2GF ssmFRAVfoXMXy7JdM7peS6bYvjd94FUbwnuP9eDbkzPrtnnfOS/cLHXOiDkwOlhj+S9ri7eT n/f8/lKWX3lE+luedh1j/s+7J/y2LV076ZnY3aV6aTvb372xWf++bMdC4y0uhRnVVtuUWIoz Eg21mIuKEwH8YbqtlAIAAA== X-CMS-MailID: 20190513090122eucas1p291c343e135fc9f2fc0a35c9756ff6f2f X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190511014656epcas1p42f3f8cf10ab875cb0cb1c2bf9b28e85e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190511014656epcas1p42f3f8cf10ab875cb0cb1c2bf9b28e85e References: <58882-1557539125.040984@0wLk.G1UB.-8BX> On Sat, 2019-05-11 at 03:45 +0200, Oliver Kiddle wrote: > I'm fairly certain that the second part of the patch renders the lines > removed in the first part as dead code but it'd be good if someone else > could check my logic which is as follows: Given -p, typeset_single() is > only now called when -m is set. usepm will always then be true because > with -m, pm will always be set and never with PM_UNSET. So we go into > the if (usepm) block on line 2193 which has early returns on every > branch. That certainly looks plausible but you could always put a DPUTS() check there. pws