From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 153b1e18 for ; Wed, 22 May 2019 08:50:18 +0000 (UTC) Received: (qmail 29886 invoked by alias); 22 May 2019 08:50:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44351 Received: (qmail 18359 invoked by uid 1010); 22 May 2019 08:50:02 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25454. spamassassin: 3.4.2. Clear:RC:0(210.118.77.12):SA:0(-7.0/5.0):. Processed in 2.186597 secs); 22 May 2019 08:50:02 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.12 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190522084924euoutp026a3e035cb61bf6d74204efdf98c39361~g9RpJF7x_1661616616euoutp026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1558514964; bh=+4qk6Ctj6otkbCC5RHgy9KJiDYXoEfGxUMw1/8SO9TU=; h=Subject:From:To:Date:In-Reply-To:References:From; b=gfjVOiG5K9+1byyVscFN/rdTez2xEUWODtKBrn/alhIlZatovlCnD5ptbcdXXAVvV EWuRBRs7imoWy2jRFf2qvDyrAB8kdU6nZvDxkZPSnH6fTU80Q4RghO85rvfvwSvZIP 2pkbUyIS8SYwhXw8zyk2iYbE3ciBRPyOqbEDaNf0= X-AuditID: cbfec7f4-113ff70000001119-f7-5ce50d13d8e7 Message-ID: <1558514961.5043.7.camel@samsung.com> Subject: Re: segfault via completion menu From: Peter Stephenson To: Date: Wed, 22 May 2019 09:49:21 +0100 In-Reply-To: X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djPc7rCvE9jDD4eVrQ42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGSv+LWMrOMFV0XXlIEsD40mOLkZODgkBE4mfF/4xdjFycQgJ rGCUeHxsLhOE08ckcfrXf2YIp5dJoqP9MStMy7nr76GqljNKHHvZjVA1+fpDVgjnDKPE7LaZ UJMvMEos6d/HCNLPK2AocX3TK6B+Dg5hAU2J9ze8QMJsQOGpm2aDlYgISEpcaz4NZrMIqEoc 2zyPEaScUyBQ4lUr1BUaEhtuHmOCmCgocXLmExYQm1lAXqJ562ywgyQEHrNJLGlfyw7R4CKx ua2XDcIWlnh1fAtUXEbi9OQeFoiGdkaJNZNes0M4PYwSm47eYYSospbou30R7ApmoKPX79KH CDtKHD6/hBkkLCHAJ3HjrSDEEXwSk7ZNhwrzSnS0CUFUq0nsaNrKCBGWkXi6RmECo9IsJB/M QvLBLIRVCxiZVzGKp5YW56anFhvlpZbrFSfmFpfmpesl5+duYgSmgtP/jn/ZwbjrT9IhRgEO RiUeXouHj2OEWBPLiitzDzFKcDArifCePvUoRog3JbGyKrUoP76oNCe1+BCjNAeLkjhvNcOD aCGB9MSS1OzU1ILUIpgsEwenVANjy5RtrfEMe7+LfW6pPs69dKuFbniX/Yl7mreO2xZvyVCa LLdCMjtaXUA84/qyg37B8fZ79X3Es7aE7927XuRhnMZ+i9oy51a3Hg5LM5m2MxcDBO7PEPY6 sSPGNfT0jkv+uzKuNr00/NzGPVvqicd7A5aap581H5ekqbiV3cw7aB5uZqwWaqnEUpyRaKjF XFScCABkD0rSAQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xe7pCvE9jDC4tULU42PyQyYHRY9XB D0wBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6 GSv+LWMrOMFV0XXlIEsD40mOLkZODgkBE4lz198zdTFycQgJLGWUODpjATtEQkbi05WPULaw xJ9rXWwQRd1MEgc3vIDqOMMoceTPIRaQKiGBC4wSb7/ngdi8AoYS1ze9Airi4BAW0JR4f8ML JMwGFJ66aTYjiC0iIClxrfk0mM0ioCpxbPM8RpByToFAiVetrBATrzBJ3G8wA7GZgaa0bv8N dY+GxIabx5ggNglKnJz5hAWiRl6ieets5gmMQrOQtMxCUjYLSdkCRuZVjCKppcW56bnFhnrF ibnFpXnpesn5uZsYgYG/7djPzTsYL20MPsQowMGoxMP74N7jGCHWxLLiytxDjBIczEoivKdP PYoR4k1JrKxKLcqPLyrNSS0+xGgK9M9EZinR5HxgVOaVxBuaGppbWBqaG5sbm1koifN2CByM ERJITyxJzU5NLUgtgulj4uCUamCsTUqvv8th++VQcN7EXzNP70++J9/4ls3ehLFWdFP+Rx79 Pf946g1C1ELr3rZv3FF2JXKd2oEVj0OCH382u9td2iZ0Xe5R7MPkbRn/cg4mHPnwa+XG723z g+dUnlc95vcjn/kEw6zCb1skooxyqtY37DW81hWtP13jET//TJ3jMZpNl65PX/tHiaU4I9FQ i7moOBEAArvO8ZICAAA= X-CMS-MailID: 20190522084922eucas1p1eb4ff5cf37faf32cc0bec060b144f41e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190521222035epcas2p295fe9ea74a0ef2c74752ee1c6ecf5351 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190521222035epcas2p295fe9ea74a0ef2c74752ee1c6ecf5351 References: <92606-1558385755.382793@sll5.5oha.0as1> <90e15b90-14bb-4ef0-9aef-cc15c0fa0935@www.fastmail.com> On Tue, 2019-05-21 at 15:19 -0700, Bart Schaefer wrote: > On Tue, May 21, 2019 at 2:59 PM Daniel Shahaf wrote: > If an error occurs as a result of NEWHEAPS()/OLDHEAPS() in the context > of workers/36853, it ought to be traceable to something leaking > heap-allocated storage across boundaries, and probably means there was > a memory leak when interrupting a pattern match before, which this has > turned into an error by freeing the previously leaked space. This is really just saying the same thing a different way, but --- the original crash was in patmatch() when looking at the pattern code, which is set up when we compile a pattern in a different function.  So there's probably some path where it's possible not to recompile a pattern or reuse a pattern without recompiling, or simply hang on to it too long. It'll be something in the prog passed into pattry() from evalcond() and I'm guesing in this case the pprog in that function came from stat->prog->pats[npat] so was fished out of the existing programme rather than compiled locally. In general (and fairly obviously), anything stored long term in compiled code is in permanent (i.e. explicitly freed) storage and if the value is on the heap it should only have been parsed or copied from permanent storage for immediate use. pws