From: Sven Wischnowsky <wischnow@berkom.de>
To: zsh-workers@sunsite.dk
Subject: PATCH: Re: _rsync duplicated options in completion
Date: Tue, 21 May 2002 09:37:43 +0200 [thread overview]
Message-ID: <15593.63815.145833.101936@wischnow.berkom.de> (raw)
In-Reply-To: <1020516171040.ZM19537@candle.brasslantern.com>
Bart Schaefer wrote:
> ...
>
> There additionally seems to be a navigation problem with menu selection.
> Complete after `rsync --' (so that all combinations of options are in
> the menu) and then begin scrolling down. On an 80-column terminal, you
> ventually come to a place where a blank line appears in the display. If
> you scroll down across this, you can't scroll back up again; rather you
> have to cycle off the bottom to get back to the top.
There was an obiwan-error: lines could get exactly $COLUMNS characters
long, caused the known display bug (we still don't have the code to
portably output in the last column, do we?). I wanted the code to
avoid that, but...
Bye
Sven
Index: Src/Zle/computil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/computil.c,v
retrieving revision 1.78
diff -u -r1.78 computil.c
--- Src/Zle/computil.c 14 May 2002 08:01:19 -0000 1.78
+++ Src/Zle/computil.c 21 May 2002 07:37:45 -0000
@@ -579,8 +579,8 @@
memset(buf, ' ', cd_state.pre);
memcpy(buf, str->str, str->len);
strcpy(sufp, str->desc);
- if (strlen(buf) >= columns)
- buf[columns] = '\0';
+ if (strlen(buf) >= columns - 1)
+ buf[columns - 1] = '\0';
*dp++ = ztrdup(buf);
}
*mp = *dp = NULL;
--
Sven Wischnowsky wischnow@berkom.de
prev parent reply other threads:[~2002-05-21 7:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-15 20:52 Wayne Davison
2002-05-16 2:18 ` Clint Adams
2002-05-16 17:10 ` Bart Schaefer
2002-05-18 16:46 ` Wayne Davison
2002-05-21 7:43 ` PATCH: " Sven Wischnowsky
2002-05-23 12:18 ` Sven Wischnowsky
2002-05-21 7:37 ` Sven Wischnowsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15593.63815.145833.101936@wischnow.berkom.de \
--to=wischnow@berkom.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).