zsh-workers
 help / color / mirror / code / Atom feed
* still completion in quotes
@ 2002-05-17  5:39 Borsenkow Andrej
  2002-05-17 18:40 ` Bart Schaefer
  2002-05-21  7:46 ` PATCH: " Sven Wischnowsky
  0 siblings, 2 replies; 3+ messages in thread
From: Borsenkow Andrej @ 2002-05-17  5:39 UTC (permalink / raw)
  To: 'Zsh hackers list'

bor@itsrm2% ls
a b       c\ d      uudecode
bor@itsrm2% zsh -c "ls a\\TAB
bor@itsrm2% zsh -c "ls aa\\*

sorry?

-andrej


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: still completion in quotes
  2002-05-17  5:39 still completion in quotes Borsenkow Andrej
@ 2002-05-17 18:40 ` Bart Schaefer
  2002-05-21  7:46 ` PATCH: " Sven Wischnowsky
  1 sibling, 0 replies; 3+ messages in thread
From: Bart Schaefer @ 2002-05-17 18:40 UTC (permalink / raw)
  To: 'Zsh hackers list'

On May 17,  9:39am, Borsenkow Andrej wrote:
} Subject: still completion in quotes
}
} bor@itsrm2% zsh -c "ls a\\TAB
} bor@itsrm2% zsh -c "ls aa\\*

I can reproduce the doubling of the "a", there.  Probably got introduced
by the patch for the segfault.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 3+ messages in thread

* PATCH: Re: still completion in quotes
  2002-05-17  5:39 still completion in quotes Borsenkow Andrej
  2002-05-17 18:40 ` Bart Schaefer
@ 2002-05-21  7:46 ` Sven Wischnowsky
  1 sibling, 0 replies; 3+ messages in thread
From: Sven Wischnowsky @ 2002-05-21  7:46 UTC (permalink / raw)
  To: zsh-workers


Borsenkow Andrej wrote:

> bor@itsrm2% ls
> a b       c\ d      uudecode
> bor@itsrm2% zsh -c "ls a\\TAB
> bor@itsrm2% zsh -c "ls aa\\*
> 
> sorry?

Oh, das ist gemein ;-)

Well, yes, we had to treat that backslash-at-the-end special
elsewhere, so we have to do the same in the nested-quotes case, too.
Right.


Bye
  Sven

Index: Src/Zle/compcore.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compcore.c,v
retrieving revision 1.58
diff -u -r1.58 compcore.c
--- Src/Zle/compcore.c	15 May 2002 07:40:36 -0000	1.58
+++ Src/Zle/compcore.c	21 May 2002 07:45:14 -0000
@@ -1428,8 +1428,8 @@
     for (p = ns, i = swb; *p; p++, i++) {
 	if (INULL(*p)) {
 	    if (i < scs) {
-		if (*p == Bnull && p[1]) {
-                    if (remq)
+		if (*p == Bnull) {
+                    if (p[1] && remq)
                         swb -= 2;
                     if (odq) {
                         swb--;
@@ -1526,6 +1526,10 @@
 	    untokenize(ss);
 	    compsuffix = ztrdup(ss);
 	}
+        if ((i = strlen(compprefix)) &&
+            compprefix[i - 1] == '\\' && compprefix[i - 2] != '\\')
+            compprefix[i - 1] = '\0';
+        
 	tmp = tricat(compqiprefix, compiprefix, multiquote(qp, 1));
 	zsfree(compqiprefix);
 	compqiprefix = tmp;

-- 
Sven Wischnowsky                          wischnow@berkom.de


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-05-21  7:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-17  5:39 still completion in quotes Borsenkow Andrej
2002-05-17 18:40 ` Bart Schaefer
2002-05-21  7:46 ` PATCH: " Sven Wischnowsky

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).