From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 8ff42998 for ; Thu, 11 Jul 2019 10:59:35 +0000 (UTC) Received: (qmail 17224 invoked by alias); 11 Jul 2019 10:59:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44510 Received: (qmail 12305 invoked by uid 1010); 11 Jul 2019 10:59:30 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25503. spamassassin: 3.4.2. Clear:RC:0(210.118.77.11):SA:0(-7.0/5.0):. Processed in 0.859897 secs); 11 Jul 2019 10:59:30 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.11 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190711105853euoutp016edad585911a5b3cfa9290a32e215abe~wVS_rm6Kt2481524815euoutp01G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1562842733; bh=bRGBSwmaAus5roa4V3O6i/ZhmWFktmAV6M2bBz/0ELo=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Ea0PGAh+5GyV9ub8mne7nhCiu7MmQFx5IMpONq/Frx87jJaVHhAeYD5fRrz6aTux9 GFbxo3/exvTsSdpZDcIU6OalMDfKSZqQ6Uxulj0KEZt2NgAUXfjlpjn6mk47IZ86dp Z5w76YgI4U8nXs8P4O4MeABX+2S4L4zAqz4SinBw= X-AuditID: cbfec7f4-12dff70000001119-ef-5d27166dc2ff Message-ID: <1562842730.4950.19.camel@samsung.com> Subject: Re: Segmentation fault immediately after 'unset PATH' From: Peter Stephenson To: Date: Thu, 11 Jul 2019 11:58:50 +0100 In-Reply-To: <1562842103.4950.12.camel@samsung.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsWy7djP87q5YuqxBuebuSwONj9kcmD0WHXw A1MAYxSXTUpqTmZZapG+XQJXRv/e4ILJXBXLXx9naWBs4+hi5OSQEDCROLP1K1sXIxeHkMAK RokryzpYQBJCAn1MEtMvhUEkepkkFi5ZwArTsXraP0aIxHJGiUdv57PCVS1vvAqVOcMose3l GWYI5wKjxPJ9N9i7GDk4eAWMJL7fiwYZJSxgJ/HwyxomEJtNwFBi6qbZjCC2iICkxLXm04wg 5SwCqhIzN4SDhDkFjCUuPO9lh7hCQ2LDzWNgrbwCghInZz4BO5tZQF6ieetssLUSAo/ZJBa3 v2aGaHCReNz1AqpZWOLV8S1QtozE/53zmSAa2hkl1kx6zQ7h9DBKbDp6hxGiylqi7/ZFsIuY BTQl1u/Shwg7Skz68RgsLCHAJ3HjrSDEEXwSk7ZNZ4YI80p0tAlBVKtJ7GjaClUtI/F0jcIE RqVZSD6YheSDWQirFjAyr2IUTy0tzk1PLTbKSy3XK07MLS7NS9dLzs/dxAhMA6f/Hf+yg3HX n6RDjAIcjEo8vBEvVGOFWBPLiitzDzFKcDArifDuc1eOFeJNSaysSi3Kjy8qzUktPsQozcGi JM5bzfAgWkggPbEkNTs1tSC1CCbLxMEp1cAoz130YpH5pN0TTlRacb1eWT3rw0PnsMlLbR8I /7ld0//d5/bBziiDQv2rszal8/s0zFSWFpx97Ze4fu4Di4yHiyu3/mDmqXNasMntiNHBFbmf Xs/R1dlS5f8h2WhjSMrZedXxESuMKx/2HbK4c226YsIjX4u9DHO/CyVFRW2tde8+cMH25e50 JZbijERDLeai4kQA9xQyNv8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Pd0cMfVYgztLOS0ONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe Rv/e4ILJXBXLXx9naWBs4+hi5OSQEDCRWD3tH2MXIxeHkMBSRokHh9vZIRIyEp+ufISyhSX+ XOtigyjqZpKY2f+CHcI5wyjx88o0ZgjnAqPEto3bWLoYOTh4BYwkvt+LBukWFrCTePhlDROI zSZgKDF102xGEFtEQFLiWvNpRpByFgFViZkbwkHCnALGEhee90LNP8AkMXnJZrB6ZgFNidbt v6Eu0pDYcPMY2ExeAUGJkzOfsEDUyEs0b53NPIFRaBaSlllIymYhKVvAyLyKUSS1tDg3PbfY SK84Mbe4NC9dLzk/dxMjMPS3Hfu5ZQdj17vgQ4wCHIxKPLwBD1VjhVgTy4orcw8xSnAwK4nw 7nNXjhXiTUmsrEotyo8vKs1JLT7EaAr00ERmKdHkfGBc5pXEG5oamltYGpobmxubWSiJ83YI HIwREkhPLEnNTk0tSC2C6WPi4JRqYJxt94F7h4Kc20Ndcf2ZLB1+a31YMu9z+fga3OrQle8v q2YoYqm7dLwriYvxfW+JxaRrpea62+KyujftuO1rp/c1kz9+QuI7TfFdP/Y2fTzwy3VBRNfW VRVR+ioWG4Mm3+6VPZ26by5r1FP1z5zpt/fLLlKpU/RIyjyY9uKpyCV152sMzLPfKrEUZyQa ajEXFScCAPZn5MmTAgAA X-CMS-MailID: 20190711105852eucas1p26ab6592ddccaa0cd33c8a851a31295da X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190710215257epcas2p3150c3096788c5d5a56e212b9e7067f19 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190710215257epcas2p3150c3096788c5d5a56e212b9e7067f19 References: <1562834672.4950.2.camel@samsung.com> <1562842103.4950.12.camel@samsung.com> On Thu, 2019-07-11 at 11:48 +0100, Peter Stephenson wrote: > diff --git a/Src/params.c b/Src/params.c > index 1859c7c12..95181f533 100644 > --- a/Src/params.c > +++ b/Src/params.c > @@ -3617,10 +3617,18 @@ unsetparam_pm(Param pm, int altflag, int exp) >   altpm = (Param) paramtab->getnode(paramtab, altremove); >   /* tied parameters are at the same local level as each other */ >   oldpm = NULL; > - while (altpm && altpm->level > pm->level) { > -     /* param under alternate name hidden by a local */ > -     oldpm = altpm; > -     altpm = altpm->old; > + /* > +  * Look for param under alternate name hidden by a local. > +  * If this parameter is special, however, the visible > +  * parameter is the special and the hidden one is keeping > +  * and old value --- we just mark the visible one as unset. > +  */ > + if (altpm && !(altpm->node.flags & PM_SPECIAL)) > + { > +     while (altpm && altpm->level > pm->level) { > + oldpm = altpm; > + altpm = altpm->old; > +     } >   } >   if (altpm) { >       if (oldpm && !altpm->level) { Hmm... can that loop I've "if"ed out ever be right?  It's meaning we're unsetting the saved version of a parameter, not the visible one.  That looks pretty fishy at any time. pws