From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: Valgrind tests (was: Re: Zsh: [7] + 23074 suspended (tty output))
Date: Mon, 15 Jul 2019 09:54:36 +0100 [thread overview]
Message-ID: <1563180876.4386.1.camel@samsung.com> (raw)
In-Reply-To: <CAKc7PVDhBe0eK4ZD8P=JK3zBco53_aR_mw8HLcYj8T3u7GesMQ@mail.gmail.com>
On Mon, 2019-07-15 at 00:17 +0200, Sebastian Gniazdowski wrote:
> On Sun, 14 Jul 2019 at 08:39, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Ok. I've waited 9 days and I'm afraid that the patch will get lost
> somewhere. I just want to say, that the thing isn't actually a patch.
> It's a tool that makes the current tests go through Valgrind. The
> patch that adds the 'VALGRIND=1' variable to the tests' Makefile is a
> +-2 lines patch. Therefore could someone else take a look? There's not
> much to review.
I don't mind the handler code changing, to make it easy to run tests
slightly different, but I'd prefer to add a more general mechanism
that's more like how the current system works...
This would mean running
make ZTST_handler=vruntests.zsh
or you can simply set that in the environment.
pws
diff --git a/Test/Makefile.in b/Test/Makefile.in
index 083df4942..09f37bf53 100644
--- a/Test/Makefile.in
+++ b/Test/Makefile.in
@@ -40,16 +40,21 @@ INSTALL = @INSTALL@
# ========== DEPENDENCIES FOR TESTING ==========
+# If ZTST_handler is not empty, run that instead of runtests.zsh.
+# It's assumed to be found in the source directory.
check test:
if test -n "$(DLLD)"; then \
cd $(dir_top) && DESTDIR= \
$(MAKE) MODDIR=`pwd`/$(subdir)/Modules install.modules > /dev/null; \
fi
+ if test -z "$$ZTST_handler"; then \
+ ZTST_handler=runtests.zsh; \
+ fi; \
if ZTST_testlist="`for f in $(sdir)/$(TESTNUM)*.ztst; \
do echo $$f; done`" \
ZTST_srcdir="$(sdir)" \
ZTST_exe=$(dir_top)/Src/zsh@EXEEXT@ \
- $(dir_top)/Src/zsh@EXEEXT@ +Z -f $(sdir)/runtests.zsh; then \
+ $(dir_top)/Src/zsh@EXEEXT@ +Z -f $(sdir)/$$ZTST_handler; then \
stat=0; \
else \
stat=1; \
next prev parent reply other threads:[~2019-07-15 8:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 17:22 Zsh: [7] + 23074 suspended (tty output) TS
2018-09-15 18:10 ` Bart Schaefer
2018-09-15 18:51 ` TS
2018-09-15 19:06 ` TS
2018-09-16 8:40 ` Vincent Lefevre
2018-09-16 15:40 ` TS
2018-09-16 17:51 ` Peter Stephenson
2018-09-17 20:13 ` TS
2018-09-18 17:59 ` Peter Stephenson
2018-09-18 1:16 ` Vincent Lefevre
2018-09-18 17:58 ` Peter Stephenson
2018-09-20 12:01 ` Vincent Lefevre
2018-09-20 16:11 ` Daniel Shahaf
2018-09-18 19:30 ` TS
2018-09-19 3:38 ` TS
2018-09-19 14:23 ` Daniel Tameling
2018-09-19 16:12 ` Peter Stephenson
2018-09-19 18:15 ` TS
2018-09-17 14:01 ` Sebastian Gniazdowski
2018-09-17 14:49 ` Valgrind tests (was: Re: Zsh: [7] + 23074 suspended (tty output)) Daniel Shahaf
2018-09-18 5:21 ` Sebastian Gniazdowski
2018-09-18 15:55 ` Daniel Shahaf
2018-09-19 5:04 ` Sebastian Gniazdowski
2019-07-03 23:29 ` Sebastian Gniazdowski
2019-07-03 23:31 ` Sebastian Gniazdowski
2019-07-03 23:45 ` Sebastian Gniazdowski
2019-07-13 14:31 ` Sebastian Gniazdowski
2019-07-14 6:39 ` Daniel Shahaf
2019-07-14 22:17 ` Sebastian Gniazdowski
2019-07-15 8:54 ` Peter Stephenson [this message]
2019-07-15 9:29 ` Peter Stephenson
2019-07-15 18:45 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563180876.4386.1.camel@samsung.com \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).