From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d1cb0b34 for ; Mon, 15 Jul 2019 08:55:27 +0000 (UTC) Received: (qmail 10409 invoked by alias); 15 Jul 2019 08:55:17 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44523 Received: (qmail 13775 invoked by uid 1010); 15 Jul 2019 08:55:17 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25510. spamassassin: 3.4.2. Clear:RC:0(210.118.77.12):SA:0(-7.0/5.0):. Processed in 2.535845 secs); 15 Jul 2019 08:55:17 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.12 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190715085438euoutp02dfd1890f7f4b9a65cf906f212a6fc97f~xiLooDml00917809178euoutp02L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1563180878; bh=MkIEWC+nWSfu2xi5HYhNVrwwdF3+7jXSKJ1SDKJ3eqY=; h=Subject:From:To:Date:In-Reply-To:References:From; b=g8tejM87NBlqPJ7z1PgL1yr4IicfQt95RHaT3CRQEX5goDLdog8nqLz8uyiYccvca EnDPM+BFeHhXNMiiQz5WFkbWk0f9yC55WAoXt3G4BO7O0VRzOp1XIVWjH0Noq+8pp5 q/jF8uK2MIP9XCBXdE1oBQSmMzQCP/EMJPCGdABE= X-AuditID: cbfec7f4-113ff70000001119-a6-5d2c3f4e373e Message-ID: <1563180876.4386.1.camel@samsung.com> Subject: Re: Valgrind tests (was: Re: Zsh: [7] + 23074 suspended (tty output)) From: Peter Stephenson To: Date: Mon, 15 Jul 2019 09:54:36 +0100 In-Reply-To: X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djP87p+9jqxBi3HWSwONj9kcmD0WHXw A1MAYxSXTUpqTmZZapG+XQJXxoMLPUwFc/kqOjbsZW9gvM3dxcjJISFgItH2q4+pi5GLQ0hg BaPEvuunoZw+JolX00+zQji9TBJfpq1lhWm5O7+XCcQWEljOKLHxozGEDVS0+IkWRMMZRon/ /VtZIJwLjBJnb91lBqniFTCUaD3WDDZJWCBAYtLVk2wgNhtQfOqm2YwgtoiApMS15tNgNouA qsTHVcvB6jkFAiWmX7jDCHGFhsSGm8eYIGYKSpyc+YQFxGYWkJdo3jqbGWSxhMB9NonXd++z QDS4SOxee58dwhaWeHV8C5QtI/F/53wmiIZ2Rok1k16zQzg9jBKbjsKss5bou30RyOYAWqEp sX6XPkTYUWLDsj+sIGEJAT6JG28FIY7gk5i0bTozRJhXoqNNCKJaTWJH01ZGiLCMxNM1ChMY lWYh+WAWkg9mIaxawMi8ilE8tbQ4Nz212CgvtVyvODG3uDQvXS85P3cTIzAVnP53/MsOxl1/ kg4xCnAwKvHwOqRoxwqxJpYVV+YeYpTgYFYS4bX9ChTiTUmsrEotyo8vKs1JLT7EKM3BoiTO W83wIFpIID2xJDU7NbUgtQgmy8TBKdXAqF8SvdcxRmvW4Yp24yYbmxX+iZPqu46YbDxz58HV VbM3ib7ic9QW3D371Eu+ST9OzG9/ZzHPePP39bOm2t8RzwmNNAmKjvF957PxCMubpXw/W2/0 Hnq/te+9ba21h1jR+Rd7WWpmtaVMdOlZ6//6LqOTRfDnbO1vPgsm2MRP2Xzp5SZDn6ikPCWW 4oxEQy3mouJEAHg+eWcBAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e/4PV1fe51YgwNL2S0ONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe xoMLPUwFc/kqOjbsZW9gvM3dxcjJISFgInF3fi9TFyMXh5DAUkaJg9/nsEMkZCQ+XfkIZQtL /LnWxQZR1M0k8exBOyuEc4ZR4tCioywQzgVGifNTuhlBWngFDCVajzWzgtjCAgESk66eZAOx 2YDiUzfNBqsREZCUuNZ8GsxmEVCV+LhqOVg9p0CgxPQLdxghhl5hk2j9exIswSygKdG6/TfU TRoSG24eY4JYJihxcuYTFogaeYnmrbOZJzAKzULSMgtJ2SwkZQsYmVcxiqSWFuem5xYb6hUn 5haX5qXrJefnbmIERsC2Yz8372C8tDH4EKMAB6MSD69DinasEGtiWXFl7iFGCQ5mJRFe269A Id6UxMqq1KL8+KLSnNTiQ4ymQB9NZJYSTc4HRmdeSbyhqaG5haWhubG5sZmFkjhvh8DBGCGB 9MSS1OzU1ILUIpg+Jg5OqQZG7n1TanyPin26X1fwYYON7qPIv6Vmd6xmKYb7HmNknah7XntK emg0i6OPYnGhRUeM/wq33Z1WfR2N/cuWd13oN1xTODkhts1pXjPPzOlTVnf3apRznysXuPWr uPOT8J6TG7ieW3//+X6V7eW1po/OhWqvO2PRnriF91AT9/d81Q9yD60PKmgqsRRnJBpqMRcV JwIAubHgQ5YCAAA= X-CMS-MailID: 20190715085437eucas1p24b8d8e852be684bf2c63373c9b979186 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190714222159epcas1p160f619296c9940dd7f21c481ce5f9ed1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190714222159epcas1p160f619296c9940dd7f21c481ce5f9ed1 References: <1537195773.3258650.1510860136.6AA9F0BA@webmail.messagingengine.com> <1537286139.1154549.1512322472.101174D6@webmail.messagingengine.com> <20190714063909.x2ndaxy2wpjksgxb@tarpaulin.shahaf.local2> On Mon, 2019-07-15 at 00:17 +0200, Sebastian Gniazdowski wrote: > On Sun, 14 Jul 2019 at 08:39, Daniel Shahaf wrote: > Ok. I've waited 9 days and I'm afraid that the patch will get lost > somewhere. I just want to say, that the thing isn't actually a patch. > It's a tool that makes the current tests go through Valgrind. The > patch that adds the 'VALGRIND=1' variable to the tests' Makefile is a > +-2 lines patch. Therefore could someone else take a look? There's not > much to review. I don't mind the handler code changing, to make it easy to run tests slightly different, but I'd prefer to add a more general mechanism that's more like how the current system works... This would mean running make ZTST_handler=vruntests.zsh or you can simply set that in the environment. pws diff --git a/Test/Makefile.in b/Test/Makefile.in index 083df4942..09f37bf53 100644 --- a/Test/Makefile.in +++ b/Test/Makefile.in @@ -40,16 +40,21 @@ INSTALL         = @INSTALL@    # ========== DEPENDENCIES FOR TESTING ==========   +# If ZTST_handler is not empty, run that instead of runtests.zsh. +# It's assumed to be found in the source directory.  check test:   if test -n "$(DLLD)"; then \     cd $(dir_top) && DESTDIR= \     $(MAKE) MODDIR=`pwd`/$(subdir)/Modules install.modules > /dev/null; \   fi + if test -z "$$ZTST_handler"; then \ +   ZTST_handler=runtests.zsh; \ + fi; \   if ZTST_testlist="`for f in $(sdir)/$(TESTNUM)*.ztst; \             do echo $$f; done`" \    ZTST_srcdir="$(sdir)" \    ZTST_exe=$(dir_top)/Src/zsh@EXEEXT@ \ -  $(dir_top)/Src/zsh@EXEEXT@ +Z -f $(sdir)/runtests.zsh; then \ +  $(dir_top)/Src/zsh@EXEEXT@ +Z -f $(sdir)/$$ZTST_handler; then \    stat=0; \   else \    stat=1; \