From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: Feature request: ZSH_XTRACEFD variable
Date: Tue, 13 Aug 2019 10:14:10 +0100 [thread overview]
Message-ID: <1565687650.5633.1.camel@samsung.com> (raw)
In-Reply-To: <CAD8ZDTokqOTfEajquX2SKU5pLWgd85sPdRMYkxE4nF0pQhi+BA@mail.gmail.com>
On Wed, 2019-07-31 at 21:40 +0200, Timothée Mazzucotelli wrote:
> About leaks, I think file pointers are all freed in the params.c set
> and unset functions. However I'm not sure about exec.c, line 5396, in
> function execshfunc, where xtrerr was previously always reassigned to
> stderr. Now it is reassigned to a new file pointer obtained with
> fdopen(zsh_xtracefd, "w") each time, and maybe this could cause memory
> leaks.
Only just had a chance to look at this but yes, I think this is a
problem. I'm not really sure why this assignment is needed, but if it
is it should reassign to a previously opened file. Possibly the right
thing to do is to keep a separate FILE *xtrace_file which always points
to the file opened in xracefdsetfn or stderr if none (so no file
management is ever done directly on this, it's simply a pointer to the
FILE opened to the last trace file requested by the user or stderr if
none).
pws
next prev parent reply other threads:[~2019-08-13 9:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 15:08 Timothée Mazzucotelli
2019-05-18 7:55 ` Stephane Chazelas
2019-05-20 10:34 ` Stephane Chazelas
2019-07-21 15:08 ` Timothée Mazzucotelli
2019-07-21 15:22 ` Peter Stephenson
2019-07-31 19:40 ` Timothée Mazzucotelli
2019-07-31 19:45 ` Timothée Mazzucotelli
2019-07-31 21:12 ` Sebastian Gniazdowski
2019-08-13 9:14 ` Peter Stephenson [this message]
2019-08-13 15:38 ` Peter Stephenson
2019-09-10 22:19 ` Timothée Mazzucotelli
2019-09-11 8:45 ` Peter Stephenson
2020-04-19 10:30 ` Timothée Mazzucotelli
2020-04-20 14:09 ` Peter Stephenson
2020-05-02 18:02 ` Timothée Mazzucotelli
2020-05-02 21:15 ` Bart Schaefer
2020-05-03 0:06 ` Daniel Shahaf
2020-05-03 4:43 ` Roman Perepelitsa
2020-05-03 16:21 ` Daniel Shahaf
2020-05-03 19:54 ` Peter Stephenson
2020-05-03 21:06 ` Daniel Shahaf
2020-05-04 8:35 ` Peter Stephenson
2020-05-05 0:03 ` Daniel Shahaf
2020-05-05 16:36 ` Timothée Mazzucotelli
2020-05-05 16:47 ` Peter Stephenson
2020-05-05 22:19 ` Bart Schaefer
2020-09-03 13:51 ` Timothée Mazzucotelli
2020-09-04 19:48 ` Daniel Shahaf
2020-09-04 19:53 ` Bart Schaefer
2020-09-05 9:24 ` Timothée Mazzucotelli
2020-05-05 22:11 ` Bart Schaefer
2020-05-03 6:01 ` Stephane Chazelas
2020-05-03 7:07 ` Stephane Chazelas
2020-05-03 17:30 ` Peter Stephenson
2020-05-03 21:23 ` Daniel Shahaf
2020-05-04 8:26 ` Peter Stephenson
2020-05-05 20:50 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565687650.5633.1.camel@samsung.com \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).