From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id a60a3fed for ; Tue, 13 Aug 2019 09:14:57 +0000 (UTC) Received: (qmail 975 invoked by alias); 13 Aug 2019 09:14:51 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44656 Received: (qmail 29854 invoked by uid 1010); 13 Aug 2019 09:14:51 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25538. spamassassin: 3.4.2. Clear:RC:0(210.118.77.11):SA:0(-7.0/5.0):. Processed in 3.510912 secs); 13 Aug 2019 09:14:51 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.11 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190813091412euoutp01b389f7315b96e81f96b19bf4cf6c33e9~6cJ-s51gz2429024290euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1565687652; bh=y/C1MBWIhJj9m3binxGK4HLBaaCvXwb+YjyC+gVEdu4=; h=Subject:From:To:Date:In-Reply-To:References:From; b=uGNZYN5g1MWg4E7ZhmzsK0PHcfLDTW1tx+P0f4A3axZtBO4CqML4lkG03AY1E/8yJ F5NNM/2FJE9NUfDNIKdttdrKistIQiaKusp2dsopONPWZu0Pur+AWAafNTyDa/xLpD eUKYGws34o65p5wICqTWB5gpUXlcNuGEbT0AG/Wo= X-AuditID: cbfec7f4-afbff700000010d5-2c-5d527f6347f7 Message-ID: <1565687650.5633.1.camel@samsung.com> Subject: Re: Feature request: ZSH_XTRACEFD variable From: Peter Stephenson To: Date: Tue, 13 Aug 2019 10:14:10 +0100 In-Reply-To: X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7djPc7rJ9UGxBuu7DC0ONj9kcmD0WHXw A1MAYxSXTUpqTmZZapG+XQJXxucTLewFu9krLj82b2BsYOti5OSQEDCRuNvcxtLFyMUhJLCC UaKzYRIzhNPHJPF57V42CKeXSeLo/++sXYwcYC0n36iBdAsJLGeUOHYyA67m1oxnjBDOGUaJ yxeWsUI4Fxglfr/4wQjSwitgKHH04RlWEFtYwFhi983lYIewAcWnbpoNViMiIClxrfk0mM0i oCrxed4DdhCbUyBQ4s6fp0wQh2tIbLh5jAlipqDEyZlPWEBsZgF5ieats8F+kBB4zCbx4dxh FogGF4kF97dANQtLvDq+hR3ClpE4PbmHBaKhnVFizaTX7BBOD6PEpqN3GCGqrCX6bl9kBAUA s4CmxPpd+hBhR4k9T04xQsKFT+LGW0GII/gkJm2bzgwR5pXoaBOCqFaT2NG0FapaRuLpGoUJ jEqzkHwwC8kHsxBWLWBkXsUonlpanJueWmyUl1quV5yYW1yal66XnJ+7iRGYCE7/O/5lB+Ou P0mHGAU4GJV4eCsSAmOFWBPLiitzDzFKcDArifBeMgmKFeJNSaysSi3Kjy8qzUktPsQozcGi JM5bzfAgWkggPbEkNTs1tSC1CCbLxMEp1cAosVF+c89tP5bXuuam8/iuJGwQVI8+v1Bs89V4 9QnXfZ40epYYS2sEt8+5FFy0MVTS28Bs2pyQsx85b00zOnLTeu7Z/aqLPvBP2bHt7U9X2fX/ zvMz9oo0SFwM8uSMcZX4fyhW6KbhX1ab7c4zzrS/15mS8WxzhV2C3ybz03wlHaIX5BMv5zsr sRRnJBpqMRcVJwIAIYUCkwADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xu7rJ9UGxBitSLQ42P2RyYPRYdfAD UwBjlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7G 5xMt7AW72SsuPzZvYGxg62Lk4JAQMJE4+Uati5GLQ0hgKaPE/ymfGbsYOYHiMhKfrnxkh7CF Jf5c62IDsYUEupkk/s40hWg4wyjxadlNVgjnAqPExhsrmECqeAUMJY4+PMMKYgsLGEvsvrkc rJsNKD5102ywDSICkhLXmk+D2SwCqhKf5z0A28YpEChx589TJoihDSwSiw/+AhvELKAp0br9 N9RJGhIbbh6DWiYocXLmExaIGnmJ5q2zmScwCs1C0jILSdksJGULGJlXMYqklhbnpucWG+oV J+YWl+al6yXn525iBAb+tmM/N+9gvLQx+BCjAAejEg9vRUJgrBBrYllxZe4hRgkOZiUR3ksm QbFCvCmJlVWpRfnxRaU5qcWHGE2BPprILCWanA+MyrySeENTQ3MLS0NzY3NjMwslcd4OgYMx QgLpiSWp2ampBalFMH1MHJxSDYxi0iutYpu9b9/ZwvKo3/Dkmh05p404b9v8TEvWYNPLcbr0 73D9N63a1yYm9y9HnD3r1lzNwn61iW/uOh3Lq+xLLc53yE4XcO1cJmF3adUCz5uL3FOVyz8y 7RLnr2Q3dZdcma5/IfSpqOipTiavGZf0PCtel9jNWrR18zT2gByWpRy697xjPyqxFGckGmox FxUnAgA5l+s+kgIAAA== X-CMS-MailID: 20190813091411eucas1p1ac5905978dfb50a1f81b89cc0b1e08fa X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190721150914epcas1p18b5b4b9ccc4e593e854b076a835257c7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190721150914epcas1p18b5b4b9ccc4e593e854b076a835257c7 References: <20190518075514.hbygmb5dl5wz23h5@chaz.gmail.com> <20190520103444.qyih7lvoigvf3rfx@chaz.gmail.com> <1563722540.4311.24.camel@samsung.com> On Wed, 2019-07-31 at 21:40 +0200, Timothée Mazzucotelli wrote: > About leaks, I think file pointers are all freed in the params.c set > and unset functions.  However I'm not sure about exec.c, line 5396, in > function execshfunc, where xtrerr was previously always reassigned to > stderr. Now it is reassigned to a new file pointer obtained with > fdopen(zsh_xtracefd, "w") each time, and maybe this could cause memory > leaks. Only just had a chance to look at this but yes, I think this is a problem.  I'm not really sure why this assignment is needed, but if it is it should reassign to a previously opened file.  Possibly the right thing to do is to keep a separate FILE *xtrace_file which always points to the file opened in xracefdsetfn or stderr if none (so no file management is ever done directly on this, it's simply a pointer to the FILE opened to the last trace file requested by the user or stderr if none). pws