From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Johan Grande <nahoj@crans.org>, zsh-workers@zsh.org
Subject: Re: Failed pipeline doesn't err_exit/return if complex command last
Date: Thu, 20 Jul 2023 09:47:37 +0100 (BST) [thread overview]
Message-ID: <1567526010.959021.1689842857292@mail.virginmedia.com> (raw)
In-Reply-To: <1570386064.868183.1689688640076@mail.virginmedia.com>
> On 18/07/2023 14:57 Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> > fn () {
> > emulate -L zsh
> > setopt errreturn pipefail
> > false | {
> > true
> > }
> > print "Shouldn't get here, status $?"
> > }
>
> A bit more prodding reveals it's not actually timing that
> has this effect --- the problem is this_noerrexit being
> set to indicate something like "we're doing that complicated
> internal shell stuff and we've discovered the status is OK".
> This time it isn['t.
>
> Obviously, there could be even more complicated cases that
> still cause problems, but I think we'll just have to discover
> those. I'll write some tests that might help.
Here's the patch with some tests.
pws
diff --git a/Src/jobs.c b/Src/jobs.c
index dd7bba405..a3b9f667a 100644
--- a/Src/jobs.c
+++ b/Src/jobs.c
@@ -427,11 +427,17 @@ storepipestats(Job jn, int inforeground, int fixlastval)
}
if (fixlastval) {
- if (jn->stat & STAT_CURSH) {
- if (!lastval && isset(PIPEFAIL))
- lastval = pipefail;
- } else if (isset(PIPEFAIL))
- lastval = pipefail;
+ if (jn->stat & STAT_CURSH) {
+ if (!lastval && isset(PIPEFAIL)) {
+ if (inforeground)
+ this_noerrexit = 0;
+ lastval = pipefail;
+ }
+ } else if (isset(PIPEFAIL)) {
+ if (inforeground)
+ this_noerrexit = 0;
+ lastval = pipefail;
+ }
}
}
diff --git a/Test/E01options.ztst b/Test/E01options.ztst
index 533e08773..83f0371a1 100644
--- a/Test/E01options.ztst
+++ b/Test/E01options.ztst
@@ -1379,6 +1379,64 @@ F:Regression test for workers/41811
>1
>2
+ pipefailfn1() {
+ emulate -L zsh
+ setopt errreturn pipefail
+ false | { true; }
+ print "Shouldn't get here, status $?"
+ }
+ pipefailfn1
+1:PIPE_FAIL causes ERR_RETURN with complex end of pipeline: braces
+
+ pipefailfn2() {
+ emulate -L zsh
+ setopt errreturn pipefail
+ false | if true; then true; fi
+ print "Shouldn't get here, status $?"
+ }
+ pipefailfn2 || print Function failed, as expected
+0:PIPE_FAIL causes ERR_RETURN with complex end of pipeline: if
+>Function failed, as expected
+
+ pipefailfn3() {
+ emulate -L zsh
+ setopt errreturn pipefail
+ false | while true; do break; done
+ print "Shouldn't get here, status $?"
+ }
+ pipefailfn3 || print Function failed, as expected
+0:PIPE_FAIL causes ERR_RETURN with complex end of pipeline: while
+>Function failed, as expected
+
+ pipefailfn4() {
+ emulate -L zsh
+ setopt errreturn pipefail
+ false | true
+ print "Shouldn't get here, status $?"
+ }
+ pipefailfn4
+1:PIPE_FAIL causes ERR_RETURN in simple case
+
+ pipefailfn5() {
+ emulate -L zsh
+ setopt errreturn pipefail
+ false | { true | true; }
+ print "Shouldn't get here, status $?"
+ }
+ pipefailfn5 || print Function failed as expected
+0:PIPE_FAIL causes ERR_RETURN with nested successful pipe
+>Function failed as expected
+
+ pipefailfn6() {
+ emulate -L zsh
+ setopt errreturn pipefail
+ false | { false | true; }
+ print "Shouldn't get here, status $?"
+ }
+ pipefailfn6 || print Function failed as expected
+0:PIPE_FAIL causes ERR_RETURN with nested failed pipe
+>Function failed as expected
+
for (( i = 0; i < 10; i++ )); do
() {
print $i
prev parent reply other threads:[~2023-07-20 8:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 23:18 Johan Grande
2023-07-05 23:45 ` Johan Grande
2023-07-06 9:44 ` Peter Stephenson
2023-07-08 4:31 ` Bart Schaefer
[not found] ` <cf275400-d63a-d991-3aa5-1543d20a2f42@crans.org>
2023-07-16 14:36 ` Peter Stephenson
2023-07-17 19:25 ` Johan Grande
2023-07-17 23:34 ` Bart Schaefer
2023-07-18 1:51 ` Bart Schaefer
2023-07-18 13:57 ` Peter Stephenson
2023-07-20 8:47 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567526010.959021.1689842857292@mail.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=nahoj@crans.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).