From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 5e00bd8a for ; Mon, 11 Nov 2019 15:47:12 +0000 (UTC) Received: (qmail 27880 invoked by alias); 11 Nov 2019 15:47:00 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44909 Received: (qmail 16252 invoked by uid 1010); 11 Nov 2019 15:47:00 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25628. spamassassin: 3.4.2. Clear:RC:0(210.118.77.12):SA:0(-7.0/5.0):. Processed in 1.944049 secs); 11 Nov 2019 15:47:00 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.12 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20191111154625euoutp02e894cfc19d077fc2f22d50c2982752de~WJkIefStC0525405254euoutp02F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1573487185; bh=1X/FNpiMpPhkT46PlzqoHRNCahdVu4l5yFdf2q9F3vI=; h=Subject:From:To:CC:Date:In-Reply-To:References:From; b=P5Q5YD+QEe6J0LbappTCf369SkzfjZZBbFU4XK8RG0yxHiPjbo6B1Umh/Qh2zYOKS xir0BbfmquPrfZBdaGZTpLAn6+5wccP4lojgDt0Q6q6OIhNhSHb6wSEDrwoclqUJWy GEhsI3iIKEBKyX/xzBoUSJ44xen8gSLp3F0v/B3Y= X-AuditID: cbfec7f4-afbff700000010d5-8f-5dc982502a6a Message-ID: <1573487183.4561.11.camel@samsung.com> Subject: Re: [BUG] Crash when accessing WIDGETSTYLE from SIGINT trap From: Peter Stephenson To: Roman Perepelitsa CC: Zsh hackers list Date: Mon, 11 Nov 2019 15:46:23 +0000 In-Reply-To: X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsWy7djPc7oBTSdjDdY+s7KY9P4Fo8XB5odM DkweO2fdZfdYdfADUwBTFJdNSmpOZllqkb5dAlfG2RetrAV9XBULHj9hbWDs5ehi5OCQEDCR ePxCrYuRi0NIYAWjxLVTzSwQzhdGib9rLrNBOJ8ZJf6vWwqU4QTrmNfUywiRWM4o8fDUXYSq xf/vs0I4Zxglli1pgBp2gVHiwp8PrCD9vAJGErNbtzKD2MICLhI/v55kB7HZBAwlpm6azQhi iwgYS9yf+4EJxGYW0JLoubSfCeRaFgFVif8/ckDCnAKBEq+vX2WDOElDYsPNY0wQ4wUlTs58 wgLRKi/RvHU2M8gNEgK/2ST6F65mgmhwkXizcAWULSzx6vgWdghbRuL05B4WiIZ2Rok1k16z Qzg9jBKbjt5hhKiylui7fZER5CJmAU2J9bv0IcKOEle/72KFBCufxI23ghBH8ElM2jadGSLM K9HRJgRRrSaxo2kr4wRG5VlIzp6F5OxZCPMXMDKvYhRPLS3OTU8tNspLLdcrTswtLs1L10vO z93ECEwQp/8d/7KDcdefpEOMAhyMSjy8DAknY4VYE8uKK3MPMUpwMCuJ8O6oOBErxJuSWFmV WpQfX1Sak1p8iFGag0VJnLea4UG0kEB6YklqdmpqQWoRTJaJg1OqgVGPafXU399Lljj/4CnW E9QWdmCZMKFZcevyy4VrUnlf9knIRX+NmWS01vfM+U0vY1bfUvsjGn/R4l6/uMG8w58Yu44n vJaX/3PszYrfv3id77Gwvqq0rHRcqveiRtC+ams106pTh9gNb1q86ph0NTVgfyfn7+IXHV+/ zjh+d/Wv+5PzuOwqfFWVWIozEg21mIuKEwGziEtgDAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t/xe7oBTSdjDT7Ol7OY9P4Fo8XB5odM DkweO2fdZfdYdfADUwBTlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1N SmpOZllqkb5dgl7G2RetrAV9XBULHj9hbWDs5ehi5OSQEDCRmNfUy9jFyMUhJLCUUaJ5eQcj REJG4tOVj+wQtrDEn2tdbBBFHxklDnw+D9VxhlFib3M3lHOBUWLFrpNMIC28AkYSs1u3MoPY wgIuEj+/ngQbxSZgKDF102ywFSICxhL3534Aq2cW0JLoubQfyObgYBFQlfj/IwckzCkQKPH6 +lWozdOYJDZc3ssIUa8p0br9N9R5GhIbbh6D2isocXLmExaIGnmJ5q2zmScwCs9C0jILSdks JGULGJlXMYqklhbnpucWG+oVJ+YWl+al6yXn525iBMbKtmM/N+9gvLQx+BCjAAejEg8vQ8LJ WCHWxLLiytxDjBIczEoivDsqTsQK8aYkVlalFuXHF5XmpBYfYjQFemgis5Rocj4wjvNK4g1N Dc0tLA3Njc2NzSyUxHk7BA7GCAmkJ5akZqemFqQWwfQxcXBKNTBWRupc/TWb9/Id++Anj8N5 /cU25cufnJsnckc0TyZecuG+i5/V1LXO/xZLLo60PZ3s7xDAk92x8N2tu39XKU6rDdT7pa4c /HbG69ZtYh9/yJr865ds4uV8dTR6R1ffkVlGgTuO7lVIknK483mB2lePZ9o+szqnC574+XpW ULOl+qnIkBsuX1OUWIozEg21mIuKEwHUru/4qwIAAA== X-CMS-MailID: 20191111154624eucas1p23cd961a65dc5c47567b293b864f3f55a X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20191111143952eucas1p2784d9821f292f2c9c136b19da5a56ade X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20191111143952eucas1p2784d9821f292f2c9c136b19da5a56ade References: <1573484293.4561.8.camel@samsung.com> On Mon, 2019-11-11 at 16:40 +0100, Roman Perepelitsa wrote: > On Mon, Nov 11, 2019 at 3:58 PM Peter Stephenson > wrote: > >  > >  > > On Mon, 2019-11-11 at 15:38 +0100, Roman Perepelitsa wrote: > > >  > > > Crash at zle_params.c:436 due to bindk being null: > > >  > > >     Widget widget = bindk->widget; > > Looks to me like returning the empty string in that case would be fine? > I don't know. I haven't sent a patch because I'm not sure whether the > fix should be right there in get_widgetstyle or somewhere earlier so > that bindk is not null to begin with. I think there are highly likely to be such cases.  Look in zlecore() where bindk is set.  We test for bindk NULL there after reading it. You've got an asynchronous event so you don't know where that's going to happen.  (There's a good chance signals are actually blocked at *that* point, I didn't follow that through, but this is just an example.) The only alternative I can think of would be queuing signals in more places, but that's quite a heavyweight change that requires a good deal of thinking through.  I think a NULL check in both places is entirely unobjectionable. (That doesn't mean everything else is *ncessarily* great, obviously...) pws