From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: git worktree add /foo <TAB>
Date: Mon, 14 Aug 2017 13:57:33 +0200 [thread overview]
Message-ID: <15766.1502711853@thecus.kiddle.eu> (raw)
In-Reply-To: <20170809193113.3gjq3ezigb6yvdu4@tarpaulin.shahaf.local2>
On 9 Aug, Daniel Shahaf wrote:
> The second argument to 'git worktree add' can be any committish. That
> committish becomes HEAD of the new worktree, and if it's a branch name,
> then that branch becomes the current branch of the new worktree, else
> the new worktree starts as a detached HEAD.
>
> How should that be completed?
>
> Currently it's completed as follows:
>
> +++ b/Completion/Unix/Command/_git
> @@ -2026,11 +2026,7 @@ _git-worktree() {
> curcontext=${curcontext%:*}-$line[1]:
> case $line[1] in
> (add)
> if (( $words[(I)--detach] )); then
> args=( ':commit:__git_commits' )
> else
> args=( ':branch:__git_branch_names' )
> fi
I can't remember why it was done this way but I'm wondering if the
two halves of the if…else…fi are the opposite way around from the
intention. Specifying --detach would be superfluous for anything but
a branch because it is the default for any other committish so after
--detach there is sense in only completing branches. I often apply logic
such as this but it might not always be helpful, such as if --detach
comes from an alias.
Otherwise, as you say, any committish is valid and our usual approach
is to just complete them all and expect user's to set tag-order to give
preference to the matches they find most useful. I suggested years back
that we perhaps add a mechanism for giving a default tag-order and
perhaps should consider it again.
> I see __git_recent_branches but it's not precisely what I have in mind.
What would be useful in this case?
Oliver
next prev parent reply other threads:[~2017-08-14 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 19:31 Daniel Shahaf
2017-08-14 11:57 ` Oliver Kiddle [this message]
2017-08-16 4:26 ` Daniel Shahaf
2017-08-16 9:37 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15766.1502711853@thecus.kiddle.eu \
--to=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).