From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: Test failures in --disable-multibyte
Date: Fri, 3 Jan 2020 10:15:51 +0000 [thread overview]
Message-ID: <1578046551.4581.1.camel@samsung.com> (raw)
In-Reply-To: <46b2aa40-adcb-44ff-8e39-df98a9b2d235@www.fastmail.com>
On Thu, 2020-01-02 at 11:30 +0000, Daniel Shahaf wrote:
> A build-time warning, then? I.e., have configure warn if --disable-multibyte
> is selected (manually or automatically), or perhaps use a #warning at
> the C level. It could say something to the effect of "Compiling without
> multibyte support is known not to pass 'make test'. We recommend to
> rebuild with --enable-multibyte. Alternatively, fix the test suite and
> send us the patches".
>
> This will at least make the issue known to anyone who tries to disable
> multibyte support for whatever reason.
It sounds like a pretty sensible idea to mention this at the end of the
configure output, where there are a couple of other messages for issues
(typically linking but anything configuration related would seem to be
appropriate).
My gut feel would be warnings in C would be more appropriate if you knew
some actual bit of code it was compiling needed fixing, but other people
may have different attitudes to this.
pws
next prev parent reply other threads:[~2020-01-03 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 18:39 Daniel Shahaf
2019-12-31 19:46 ` Peter Stephenson
2020-01-01 13:44 ` Daniel Shahaf
2020-01-01 18:01 ` Peter Stephenson
2020-01-02 11:30 ` Daniel Shahaf
2020-01-03 10:15 ` Peter Stephenson [this message]
2020-01-03 20:11 ` [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte) Daniel Shahaf
2020-01-05 18:20 ` Peter Stephenson
2020-01-05 19:13 ` Daniel Shahaf
2020-01-06 9:44 ` Peter Stephenson
2019-12-31 20:23 ` Test failures in --disable-multibyte dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578046551.4581.1.camel@samsung.com \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).