From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id a0d6a86d for ; Mon, 13 Jan 2020 09:47:21 +0000 (UTC) Received: (qmail 10971 invoked by alias); 13 Jan 2020 09:47:13 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45293 Received: (qmail 6018 invoked by uid 1010); 13 Jan 2020 09:47:13 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25691. spamassassin: 3.4.2. Clear:RC:0(210.118.77.11):SA:0(-7.0/5.0):. Processed in 2.268285 secs); 13 Jan 2020 09:47:13 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.11 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200113094635euoutp01c59e163e7533654ae501b9a457cb3587~paS8aEVG-0303703037euoutp01o X-AuditID: cbfec7f2-f0bff7000001ef66-e9-5e1c3c7a978e Message-ID: <1578908793.4921.1.camel@samsung.com> Subject: Re: [PATCH] A glob with a trailing slash will now match unreadable/unexecutable directories. From: Peter Stephenson To: Date: Mon, 13 Jan 2020 09:46:33 +0000 In-Reply-To: <20200113002724.12708-1-danielsh@apache.org> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djPc7pVNjJxBr+PWVocbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujK9b37MU/GWueHKnpoGxi7mLkYNDQsBE4s9W1S5GLg4hgRWM EnvbNrB0MXICOX1MEl07mCDsXiaJe6sTQGyQ+h/XVrNCxJczSqw4nQjRDFTT2bGOBcI5wygx b/dlJgjnAlDVp242kBZeAUOJz5c2gY0VFkiXuLzlEDOIzQYUn7ppNiOILSIgKXGt+TSYzSKg KtH04i6YzSlgKbFgSi8jxBkaEhtuHmOCmCkocXLmE7CzmQXkJZq3zmYGWSwhcJ9NYtvmGewQ DS4SKx90sEDYwhKvjm+BistI/N85nwmioZ1RYs2k1+wQTg+jxKajd6DWWUv03b7ICAoxZgFN ifW79CHCjhLXDp9kgwQkn8SNt4IQR/BJTNo2HRq+vBIdbUIQ1WoSO5q2MkKEZSSerlGYwKg0 C8kHs5B8MAth1QJG5lWM4qmlxbnpqcWGeanlesWJucWleel6yfm5mxiBSeD0v+OfdjB+vZR0 iFGAg1GJh/dAlXScEGtiWXFl7iFGCQ5mJRHeTeek4oR4UxIrq1KL8uOLSnNSiw8xSnOwKInz Gi96GSskkJ5YkpqdmlqQWgSTZeLglGpg9BBwZpZ3njRxuYjbhG+3D9kdVN6rWzPl796jOnrC dqurOV3EZ/P9+qn0UPLHvJMfUjZzyHH9+3Z68cr9UkwnNm/40VL/gX1764xV39u8VuwOFBFc nL4v9/DdsrDNbnO5w/OML0aYS7/03xZjwhrs9f7BFE4m91WVj85LngxPPuB9KD809mWInxJL cUaioRZzUXEiAG/Gr37+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4Xd0qG5k4g9vLFCwONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe xtet71kK/jJXPLlT08DYxdzFyMkhIWAi8ePaatYuRi4OIYGljBKtq5azQiRkJD5d+cgOYQtL /LnWxQZR1M0ksXrNbXYI5wyjxO2Nh6AyFxgl/r17CzaXV8BQ4vOlTUwgtrBAusTlLYfA4mxA 8ambZjOC2CICkhLXmk+D2SwCqhJNL+6C2ZwClhILpvQyQgztZZT4dP0g2B3MApoSrdt/Q92k IbHh5jEmiGWCEidnPmGBqJGXaN46m3kCo9AsJC2zkJTNQlK2gJF5FaNIamlxbnpusZFecWJu cWleul5yfu4mRmD4bzv2c8sOxq53wYcYBTgYlXh4D1RJxwmxJpYVV+YeYpTgYFYS4d10TipO iDclsbIqtSg/vqg0J7X4EKMp0EcTmaVEk/OBsZlXEm9oamhuYWlobmxubGahJM7bIXAwRkgg PbEkNTs1tSC1CKaPiYNTqoGRbWWC7sbl6ZdsxA/5sf8Xclje/OXhp7rIx6mW3ScMkj/Uqn4Q qMy61/s+uGTF7djnD/44mX/Zom31tOvZZqm5RnWMhzSmpFrIHpnNIi3wdOP6d7lBwr8yFygl ptS5G1yTlbrX/maWiHjnJ3+Gxj4VL6l/DlyrN579lioqdfB3+JaGJclZbzOUWIozEg21mIuK EwFRhrFslQIAAA== X-CMS-MailID: 20200113094634eucas1p15da4dae138af64b95def283cc02503b4 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200113002821eucas1p2884acfad76834011d777bf81f0562c50 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200113002821eucas1p2884acfad76834011d777bf81f0562c50 References: <20200113002724.12708-1-danielsh@apache.org> On Mon, 2020-01-13 at 00:27 +0000, Daniel Shahaf wrote: > --- > This fixes the issue, but I'd appreciate some review. >  > There are some code flow changes, but the basic idea is that instead of > changing "foo/" to "foo/." and calling access(), just leave it as-is and > call stat() and S_ISDIR() instead. Looks like that should do the trick --- next step may be to try it out and see if any odd edge cases turn up. Not clear if it's needed in the release since it's not a new issue. pws