From: Oliver Kiddle <opk@zsh.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] C compatiblity fixes for the configure script (incompatible-pointer-types)
Date: Sat, 09 Dec 2023 23:13:53 +0100 [thread overview]
Message-ID: <15816-1702160033.279536@x9Iw.p0C3.hCi5> (raw)
In-Reply-To: <CAH+w=7Z+eprKOYQG8NiHgXcuKvs1b7CPvC35Ja8V20Z5i6gHLA@mail.gmail.com>
Bart Schaefer wrote:
> On Fri, Dec 8, 2023 at 12:58 PM Florian Weimer <fweimer@redhat.com> wrote:
> >
> > Avoid incompatible pointer types in terminfo global variable checks.
>
> For the record, the incompatibility seems to be that ncurses now
> declares these as arrays of const pointer to const char.
>
> Curiously (incorrectly?) the Solaris 11.3 documentation available
> online shows them as only char*, not even char**.
Checking /usr/include/term.h on 11.4 and 10, it is:
extern char term_parm_err[], *term_err_strings[], *Def_term,
*boolnames[], *boolcodes[], *boolfnames[],
*numnames[], *numcodes[], *numfnames[],
*strnames[], *strcodes[], *strfnames[];
The patch has no impact on a Solaris build.
And while I don't have a new enough compiler to verify the described
problem, I don't doubt it. I can't see adding a cast to the type it is
being assigned to causing problems so no objections from me.
Oliver
next prev parent reply other threads:[~2023-12-09 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 20:58 Florian Weimer
2023-12-09 17:12 ` Bart Schaefer
2023-12-09 22:13 ` Oliver Kiddle [this message]
2023-12-11 8:51 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15816-1702160033.279536@x9Iw.p0C3.hCi5 \
--to=opk@zsh.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).