zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@berkom.de>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: Re: completion in braces
Date: Mon, 11 Nov 2002 10:03:13 +0100	[thread overview]
Message-ID: <15823.29265.469397.574121@wischnow.berkom.de> (raw)
In-Reply-To: <E189pkm-0006C2-00@bimbo.logica.co.uk>


Apologies for not replying to the original post earlier. I meant to
answer it, even had a look at the code, couldn't find a good solution
and then got drowned by real work again.

Oliver Kiddle wrote:

> Following patch seems to fix this, at least for the new completion
> system. But I'm no expert on what's going on in the completion code so
> I'd be happier if someone else such as Sven could check this and perhaps
> get it to work for the compctl system too.

The problem with the patch is that it fixes it only for the (few)
cases where the completion code uses the compquote builtin. A better
solution would be to add the change at the place where the completion
or the unambiguous string is inserted into the line (in cline_str()
and instmatch() in compresult.c). But that's not trivial (finding the
commas that have to be quoted, ignoring those that don't have to be
quoted). It was at that place where I didn't find a good solution...
(from the code's point of view). And it's still the same, so no patch
yet.


Bye
  Sven

-- 
Sven Wischnowsky                          wischnow@berkom.de


      reply	other threads:[~2002-11-11  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-08  4:58 Danek Duvall
2002-11-07 16:43 ` PATCH: " Oliver Kiddle
2002-11-11  9:03   ` Sven Wischnowsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15823.29265.469397.574121@wischnow.berkom.de \
    --to=wischnow@berkom.de \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).