From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-37614-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 17053 invoked by alias); 14 Jan 2016 04:57:52 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 37614
Received: (qmail 29050 invoked from network); 14 Jan 2016 04:57:52 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version:content-type;
        bh=lqGW/8ay0pQyH0rKD25hzBw9KPaaRHB9TGF2gvcylVY=;
        b=HwWbannKOzvTcgezypEOZKlD6tMl5m3PGrr1XbEZAKObv6yWwFqGNlBS2AhGw8i6T9
         EQtHCdX3S2r/QxzT9C4AMnxcQogRYkWBQwVQXP9p2opVRKsHDPNWp8KBEp75Qh0XIcyA
         tPHOl5bgOedeL0t+bo5st2y37wT9tpHLNuLYO5r/3L+lMdtDKWsppzM12TjgP76hhLaa
         rD/OOmcVQ3Faqid9BdJURBJ28+2F+fONQ5mR4jrcs0irKsYZAkaVSQ/TDzgKJTtaps78
         TGaOb34iI5IcLyVx5lo/C1m/9ANjMptAeMPmGO349uRX1O8GmENO23BxuUVOTrlxdfvE
         UurA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=lqGW/8ay0pQyH0rKD25hzBw9KPaaRHB9TGF2gvcylVY=;
        b=UwaD4yrMMDpdGMVYSYsCTzIxDyj2j0PjpgFISzBpCYFEURf8tbjeCbuRz+QkgqsWm3
         OmzWn2NxijXUag168srGzIgB/ClcTZqjF05eE0lBsmZQtrspp5LquKtyYwD6zxxExOG8
         EVF2bFo7eE8yvxmqZVfI0FS2x049xk58ZbmQTc+96pBjuSCHIPMh01tk2VGLDA6r7Q+3
         5GjH5IE9B/saNMmIf7tX1nQB+Hui4ZniR8AQelyesD0k69u9phbPu4P9SqU7UHK5mcKc
         lKidYkMPSzz2JezQtxM0AoDkFqLZsqkDt0mZrsTf5wS/1Ezkwc644BHdTAuy+VvBfhff
         CxIw==
X-Gm-Message-State: ALoCoQmI1HKOaGPTzqU9DTPONuew6gfmMFOhu10FoWYwsenjJygbgTclaJ0kU4GGweRlnyHV6S84LlzqhajKbCflOXDVQGeIUg==
X-Received: by 10.98.18.208 with SMTP id 77mr3060007pfs.94.1452747470435;
        Wed, 13 Jan 2016 20:57:50 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160113205809.ZM14195@torch.brasslantern.com>
Date: Wed, 13 Jan 2016 20:58:09 -0800
In-Reply-To: <20160114001336.GA11173@tarsus.local2>
Comments: In reply to Daniel Shahaf <d.s@daniel.shahaf.name>
        "[PATCH] typeset: set $? on incidental error" (Jan 14, 12:13am)
References: <20160114001336.GA11173@tarsus.local2>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: [PATCH] typeset: set $? on incidental error
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jan 14, 12:13am, Daniel Shahaf wrote:
}
} The 'typeset' family of builtins doesn't set $? when one would expect it
} 
} This patch makes 'typeset' behave as ordiary assignment does.

Looks OK to me.  I worry that there's also some examination of errflag
needed, but what you have there doesn't seem to be wrong.