zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: V01zmodload fails on Cygwin
Date: Sun, 24 Jan 2016 10:22:44 -0800	[thread overview]
Message-ID: <160124102244.ZM11864@torch.brasslantern.com> (raw)
In-Reply-To: <F46CF6DC-AC2E-4C64-B94E-E48B3FB68141@kba.biglobe.ne.jp>

On Jan 24,  8:10pm, Jun T. wrote:
}
} V01zmodload.ztst fails on my Cygwin (on 64 bit Windows7):
} CYGWIN_NT-6.1 2.4.0(0.293/5/3) 2016-01-15 16:16 x86_64
} (probably the latest 64bit cygwin)
} 
} So it seems some symbols from libzsh-5.2-dev-1.dll also exists
} in param_private.dll, and gethashnode2 is one of those symbols:

Interesting.  gethashnode2 should be declared external, so it should
be resolved for param_private.dll at link time.  Seems to have to do
with whether the external function is *called* vs. merely referenced
by name?

} The following patch seems to work, but I hope someone who knows
} cygwin better to confirm/improve the patch.

It's too bad the node functions are direct members of the hashtable
struct rather than encapsulated the way the parameter GSUs are.  In
the absence of an entire data structure to save/restore, your patch
looks fine.  Should probably save/restore ->getnode as well, just
for completeness.

Do you want to commit or should I?


  parent reply	other threads:[~2016-01-24 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24 11:10 Jun T.
2016-01-24 12:45 ` Sebastian Gniazdowski
2016-01-24 18:22 ` Bart Schaefer [this message]
2016-01-25  1:28   ` Jun T.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160124102244.ZM11864@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).