From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-37766-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 5804 invoked by alias); 24 Jan 2016 18:22:15 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 37766
Received: (qmail 728 invoked from network); 24 Jan 2016 18:22:12 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version:content-type;
        bh=LOH3FvLgCiIRdP6XNXC/8YsbSHe4PnFQZMxRvgdXkhM=;
        b=1jmYJrXjVb2V/j79LA17une9vASiGanEDLYRx8QmNDjjobGziGcYLn4FS4jaz5hW4M
         QvI14msMkO5b5wOGuyQ0Fp91MJ6ME4l6FtMsNaYeXSzDSO9V1WhdCoi6rbOftxkVMnjg
         /Y5HqyNNRO3Cs3AOzMqQmgssFxdUlTjG875FJjloCrHYF47bzbiSxB29fq60viBJIAoW
         U6E/xww+D80IvdOvN5Oivo3NggvcfN+dinXIUM53Dq/mkh6v2gUrzGAdtQynNw9ndLDb
         M5VXguzYaBGlPV0K4UeZz2A1UjJ1Zlyg5uufgPYDd9KvNTqkESGFgU7gewUhh2vHsdEM
         dHSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=LOH3FvLgCiIRdP6XNXC/8YsbSHe4PnFQZMxRvgdXkhM=;
        b=ZCrjVvKSmSnO1ewkjqPBjvk8QUldCXLbC1whnq4DdhoMePsDc/84OJ7+36Bs5hIHKy
         O78N3f1SwvJx5YMRek2vH9EhBTiKPDL65XXmSBAbO5FwDAKinfJCE7YhltA7KhiPZEYx
         JadPHssrYkQWgjfTxop0h9/DPhjonSrrKOsKCHtvkRV7mBGmMTqpEfPX8if74/pRRGZO
         wD6mVCcSGT2D72leXkji5CLpffrZTb97y3LUlfSBrpCLrPF5xueUG/vLyyPeeqowbh9e
         H63Kc+MJQKqSd65NbDZm13zDcIoHnT33Wq4D5AjPO9rnl6DnKkfPEE+UNin7EJH1T7Gt
         yeiA==
X-Gm-Message-State: AG10YOTnXuYXfbyxIF1tAH7Dom52j7Ua691nnmx7Vv+a/e9njDCLLp9nmp1Umm+TdYlZbw==
X-Received: by 10.98.71.130 with SMTP id p2mr20167750pfi.99.1453659727242;
        Sun, 24 Jan 2016 10:22:07 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160124102244.ZM11864@torch.brasslantern.com>
Date: Sun, 24 Jan 2016 10:22:44 -0800
In-Reply-To: <F46CF6DC-AC2E-4C64-B94E-E48B3FB68141@kba.biglobe.ne.jp>
Comments: In reply to "Jun T." <takimoto-j@kba.biglobe.ne.jp>
        "V01zmodload fails on Cygwin" (Jan 24,  8:10pm)
References: <F46CF6DC-AC2E-4C64-B94E-E48B3FB68141@kba.biglobe.ne.jp>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: V01zmodload fails on Cygwin
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jan 24,  8:10pm, Jun T. wrote:
}
} V01zmodload.ztst fails on my Cygwin (on 64 bit Windows7):
} CYGWIN_NT-6.1 2.4.0(0.293/5/3) 2016-01-15 16:16 x86_64
} (probably the latest 64bit cygwin)
} 
} So it seems some symbols from libzsh-5.2-dev-1.dll also exists
} in param_private.dll, and gethashnode2 is one of those symbols:

Interesting.  gethashnode2 should be declared external, so it should
be resolved for param_private.dll at link time.  Seems to have to do
with whether the external function is *called* vs. merely referenced
by name?

} The following patch seems to work, but I hope someone who knows
} cygwin better to confirm/improve the patch.

It's too bad the node functions are direct members of the hashtable
struct rather than encapsulated the way the parameter GSUs are.  In
the absence of an entire data structure to save/restore, your patch
looks fine.  Should probably save/restore ->getnode as well, just
for completeness.

Do you want to commit or should I?