From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Error status of "repeat" (was Re: [PATCH] typeset: set $? on incidental error)
Date: Tue, 26 Jan 2016 20:15:13 -0800 [thread overview]
Message-ID: <160126201513.ZM2538@torch.brasslantern.com> (raw)
In-Reply-To: <20160126225008.GA4731@tarsus.local2>
On Jan 26, 10:50pm, Daniel Shahaf wrote:
}
} What would you expect "repeat 0+++ (exit 42)" to set $? to?
In fact what it does set $? to, is 0.
} repeat WORD do LIST done
} WORD is expanded and treated as an arithmetic expression, which
} must evaluate to a number N. LIST is then executed N times.
Hmm, this doesn't actually appear to happen.
torch% x=1+3
torch% repeat x print -n Z
torch% repeat $x print Z
Z
torch%
So it's just peeling the first thing that looks like a number off the
WORD and repeating that many times, or zero times if WORD is not a number.
BUT! Even if we change the code --
diff --git a/Src/loop.c b/Src/loop.c
index 4def9b6..61dad09 100644
--- a/Src/loop.c
+++ b/Src/loop.c
@@ -493,7 +493,7 @@ execrepeat(Estate state, UNUSED(int do_exec))
tmp = ecgetstr(state, EC_DUPTOK, &htok);
if (htok)
singsub(&tmp);
- count = atoi(tmp);
+ count = mathevali(tmp);
pushheap();
cmdpush(CS_REPEAT);
loops++;
-- that doesn't change the exit status!
torch% repeat 0+++ (exit 42)
zsh: bad math expression: lvalue required
torch% print $?
0
Next question: Do I commit that patch?
next prev parent reply other threads:[~2016-01-27 4:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 0:13 [PATCH] typeset: set $? on incidental error Daniel Shahaf
2016-01-14 4:58 ` Bart Schaefer
2016-01-14 5:24 ` Eric Cook
2016-01-15 6:26 ` Daniel Shahaf
2016-01-15 14:46 ` Mikael Magnusson
2016-01-15 14:54 ` Eric Cook
2016-01-15 15:49 ` Peter Stephenson
[not found] ` <20160118022557.GE3979@tarsus.local2>
2016-01-18 4:38 ` Mikael Magnusson
2016-01-18 13:33 ` Mikael Magnusson
2016-01-20 7:47 ` Daniel Shahaf
2016-01-20 15:00 ` Eric Cook
2016-01-23 23:53 ` Daniel Shahaf
2016-01-24 3:32 ` Eric Cook
2016-01-26 22:50 ` Daniel Shahaf
2016-01-27 4:15 ` Bart Schaefer [this message]
2016-01-27 4:38 ` Error status of "repeat" (was Re: [PATCH] typeset: set $? on incidental error) Bart Schaefer
2016-01-27 9:52 ` Peter Stephenson
2016-01-29 9:18 ` Daniel Shahaf
2016-01-29 9:29 ` Peter Stephenson
2016-01-29 10:25 ` Daniel Shahaf
2016-01-27 4:17 ` [PATCH] typeset: set $? on incidental error Bart Schaefer
2016-01-29 9:18 ` Daniel Shahaf
2016-01-30 7:46 ` typeset docs flow " Daniel Shahaf
2016-01-30 19:47 ` Bart Schaefer
2016-01-31 0:49 ` Jun T.
2016-01-31 17:03 ` Bart Schaefer
2016-02-01 3:23 ` Jun T.
2016-02-01 5:41 ` Bart Schaefer
2016-01-21 14:22 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160126201513.ZM2538@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).