zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: Unexpected foo==bar errors
Date: Mon, 8 Feb 2016 10:45:28 -0800	[thread overview]
Message-ID: <160208104528.ZM12107@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3S-Vj24041msXn6f8w3DM1pbv2uooxHUF3F=Ou8od_PxQ@mail.gmail.com>

On Feb 8,  4:52am, Mikael Magnusson wrote:
}
} On Sun, Feb 7, 2016 at 8:16 PM, Bart Schaefer <schaefer@brasslantern.com> wrote:
} [...]
} > } _tar:70 is
} > } tf=${~words[3]}
} >
} > Ooh, that's a fun one: (foo) is being taken as glob qualifiers, which is
} > a larger problem in this case than the expansion of "=".  Then because
} > globassign is off, the equals expansion (on the empty string) is done,
} > but the qualifiers are never applied to the result.

One potentially open question here is whether the value should be parsed
as a glob (qualifiers recognized) when no globbing is possible.

} > The only use of $tf as far as I can see is to do lookups in the cache.
} 
} Presumably at some point the given filename has to be interpreted so
} that it can give any completions at all, even if it's not cached?

On closer inspection yes, I'm wrong about this, $tf is passed to "tar -tf"
to list the contents of the tar file even if not found in the cache.

} I wonder if there's anywhere in the completion system that depends on
} EQUALS being set... But maybe we should just 2> /dev/null the
} assignment since tilde expansion also prints errors. (_zattr and _zip
} also have this issue, presumably there are other places as well).

Redirecting error would still leave $tf empty.  But there's no way to
cause process substitution [that is, <(...) >(...) and =(...) syntax]
to be applied to the result of parameter expansion, except by using
"eval" -- and of course globbing won't happen without GLOB_ASSIGN, so
the only reason for tf=${~words[3]} (and the other assignments in _tar
from lines 66-82) is to do tilde and equals expansion.


  reply	other threads:[~2016-02-08 18:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-07 15:57 Mikael Magnusson
2016-02-07 19:06 ` Peter Stephenson
2016-02-08  7:09   ` Bart Schaefer
2016-02-08  9:49     ` Peter Stephenson
2016-02-07 19:16 ` Bart Schaefer
2016-02-08  3:52   ` Mikael Magnusson
2016-02-08 18:45     ` Bart Schaefer [this message]
2016-02-08 19:16       ` Mikael Magnusson
2016-02-14 20:10         ` Failed process substitution on x=$~y (Re: Unexpected foo==bar errors) Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160208104528.ZM12107@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).