zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: clear-screen widget and prompt expansion
Date: Tue, 16 Feb 2016 10:43:51 -0800	[thread overview]
Message-ID: <160216104351.ZM31803@torch.brasslantern.com> (raw)
In-Reply-To: <20160216100140.GA27569@cventin.lip.ens-lyon.fr>

On Feb 16, 11:01am, Vincent Lefevre wrote:
}
} I meant that prompt is already re-expanded when the terminal is
} resized. What I'm saying is that clear-screen is not consistent
} with that.

Ah.  Well, clear-screen is a widget and existed in primordial form
long before the shell even knew about SIGWINCH, so it's not very
surprising that it hasn't been overhauled with more recent changes
to prompt handling.

This raises the question of whether redisplay (^R) should also imply
a reset-prompt.  However, it explicitly says "the edit buffer" whereas
clear-screen mentions "redraw the prompt".

}   zle -A clear-screen real-clear-screen
}   cls-rp() { zle real-clear-screen; zle reset-prompt }
}   zle -N clear-screen cls-rp
} 
} [...] doesn't work in incremental search mode

That's because incremental-search has its own input loop and does not
recognize user-defined widgets.  An entirely different problem.

Does the following break anything?


diff --git a/Src/Zle/zle_refresh.c b/Src/Zle/zle_refresh.c
index 3d2471e..7e4f328 100644
--- a/Src/Zle/zle_refresh.c
+++ b/Src/Zle/zle_refresh.c
@@ -2424,6 +2424,7 @@ clearscreen(UNUSED(char **args))
     tcoutclear(TCCLEARSCREEN);
     resetneeded = 1;
     clearflag = 0;
+    reexpandprompt();
     return 0;
 }
 


  reply	other threads:[~2016-02-16 18:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 14:12 Vincent Lefevre
2016-02-04 15:37 ` Bart Schaefer
2016-02-16 10:01   ` Vincent Lefevre
2016-02-16 18:43     ` Bart Schaefer [this message]
2016-02-19 15:16       ` Vincent Lefevre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160216104351.ZM31803@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).