From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26877 invoked by alias); 5 Mar 2016 16:35:59 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38098 Received: (qmail 28839 invoked from network); 5 Mar 2016 16:35:59 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=0S25DdIG09hxVVQdqfb9uIkOuqz0MehRRmy00HRhbLU=; b=FBF5/ueofeS1MOdXg2NE83Yfwh+HOQkyLyOHasjC0cctUaEc9mHwkpm0/v4gF4dQYD QEdTckkqBbcavb6gcxciIXgETGdAJaCf3bnGjHBphcVYQkvKB6bhEQH821QgUE4Cb9ip tY3wahN3L4VjOvdHq+G3mfcAu30AvH9GBBFWqhEWrHsc+OgLovCBHxj1Y/K0e/EShst+ P4WsrtsBPsgCTuSFqk8idOp7iZSdZ/wSZAZX7JWMpXEmEIhb9VvNAiYkQRUQGReVV1kZ wP7fhFLjAzdgARMbS8CQCJnt9jQ6vp17ziQFAOewjzI38/H98unfmRFYbKURUOROV6MN BKnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=0S25DdIG09hxVVQdqfb9uIkOuqz0MehRRmy00HRhbLU=; b=KSDOGFDZ8VBF3oiyjTpN7KqWPHPHe/JQRr8KFfCDc3XI+oHh62XAcr29tZ0dlGEJN/ gSPUlFgiF5lGakJWleWi+v9rPKesoOMePA5VPKWCH1Hhi9LRyEkvD7KKWK2T18oE1JNn 22Oz9fDn4BAQJZ5VAPmMnoBiCHinld6P9K6EazbstVfCBiSbv5d2VYoonX4pZAf84NlI HVxIXaBO8Mf1CMj5KJNEQMnJr1srt6lvTsSESBEtEReW6MyGTmnX/dJEhJNdPxVOpBln bf3j1JstQr3AHmaXlZFBYXEdNNt/jFKFme5HhCgajM0dyACicT5whsJLLM/tto20tdRL UdKg== X-Gm-Message-State: AD7BkJLePYlOraW+cummD25AXFbE6Ih2/KqgCIzC/NPwRYK/KQFUIvqq/aLnMzrKzTUQBw== X-Received: by 10.98.16.210 with SMTP id 79mr20914347pfq.69.1457195757206; Sat, 05 Mar 2016 08:35:57 -0800 (PST) From: Bart Schaefer Message-Id: <160305083558.ZM9594@torch.brasslantern.com> Date: Sat, 5 Mar 2016 08:35:57 -0800 In-Reply-To: <20160304121435.0d07611f@pwslap01u.europe.root.pri> Comments: In reply to Peter Stephenson "Re: Empty $''" (Mar 4, 12:14pm) References: <1533e4d3e82.cbf3800a134118.3897690426664036468@enosys.org> <160303153436.ZM31948@torch.brasslantern.com> <160303153647.ZM31964@torch.brasslantern.com> <20160304103502.531f6bb9@pwslap01u.europe.root.pri> <20160304121435.0d07611f@pwslap01u.europe.root.pri> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Empty $'' MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Mar 4, 12:14pm, Peter Stephenson wrote: } Subject: Re: Empty $'' } } - else } + else if (*strsub) } strret = strsub; } + else { } + /* This ensures a $'' doesn't get elided. */ } + strret = dupstring(nulstring); } + } This looks fine; I wasn't sure whether (*strsub) was ever nonzero in this case but it should be harmless to append a Nulstring to another string (happens with e.g. foo"" already I think) so I took a shortcut.