From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38121-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 16840 invoked by alias); 9 Mar 2016 15:37:45 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38121
Received: (qmail 16213 invoked from network); 9 Mar 2016 15:37:42 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version;
        bh=6/SK+qAU/DvR5plIpFP5xeXhnDMNpZLqPEkPQ7ZXERw=;
        b=U4CFAr+06+hcHPApPHWQS2yXyLmzne9e8/c8Hr0L2lQQr2DsubHCctPqs8Xj1vhbUX
         nMaJ+jn5oWn8s8Lf+glcdJp6oz5xnLaDyMke+6pRfI8TJ82JQVWL/VJFFpKkxRcC8cKi
         fgSail6bpnu+AZTujktHPfk2OD8xETB3wIsVap2qNdNM5uyNr53n7o/cPtZOgKw3r6Gf
         yBCnYglrIMEz1L5QcS89+cVdYDkOVJBUW02deD3tj14LGr1fPkQKuehbafnypcuGJIgD
         KlhHkhs0VgICvYrPtdPOVfSeKMgy7GsXEcEq/SIdJNxaLzNZqFZQqyWOB++Uuqn+dX2r
         WNdQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version;
        bh=6/SK+qAU/DvR5plIpFP5xeXhnDMNpZLqPEkPQ7ZXERw=;
        b=KBuWn0JJhscscF22v6jb3FUuLgTxBes1tj6Jo6ZcFhRVjOe3WtcpdKTl3NhMaCRVII
         kFLYeGN2S2hiq/HhMSEFwZeXdBAEBOHbpl7LgINk5IkKOfbgU+yd9224FKkXwJuUzUUu
         rMfN6/45BeWbzQ0l6C5KoLVNHPCKqqVVpp86dfHzp4bz74vN/A9sSv2LgiLVerqjnkBy
         yEGNe/p1E5OeAibg6P0tu0K/pcNTZ8zJQvF6wjSpX0N655yJuVEBg4/WcWIB6r3uyQIX
         s8T2wgUfkaOoCGU7gOTu2to9CptlBeA2z0PH7pa2n2MXm0YSlar6QSTT041Mks025MQb
         JyfA==
X-Gm-Message-State: AD7BkJI6UuvxK+9o2e4aDopMiYGs0/BxVB1J0/2GgZ6WSkkX1s3M8v/2UuLWqYlM9RMBWg==
X-Received: by 10.98.93.211 with SMTP id n80mr51584572pfj.61.1457537858751;
        Wed, 09 Mar 2016 07:37:38 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160309073746.ZM10382@torch.brasslantern.com>
Date: Wed, 9 Mar 2016 07:37:46 -0800
In-Reply-To: <20160309095506.305d64c8@pwslap01u.europe.root.pri>
Comments: In reply to Peter Stephenson <p.stephenson@samsung.com>
        "Re: Signal handling bugaboo in command substitution" (Mar  9,  9:55am)
References: <160307184406.ZM23121@torch.brasslantern.com> 
	<20160308100004.3011d110@pwslap01u.europe.root.pri> 
	<20160308101221.625cef45@pwslap01u.europe.root.pri> 
	<CAH+w=7YCFciaFG8xMFqAefj2pK2ODkwWRM=2kiA+oGDQcxaB7Q@mail.gmail.com> 
	<20160309095506.305d64c8@pwslap01u.europe.root.pri>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Signal handling bugaboo in command substitution
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Mar 9,  9:55am, Peter Stephenson wrote:
}
} It occurs to me there's probably still a very thin race associated with
} forking and then calling entersubsh() that may be wider than just this
} case.  We'd need to queue signals before the fork and unqueue them in
} both parent and child at the end of entersubsh().  It might well be more
} trouble than it's worth to fix.

It'd also be wrong -- we don't want both the parent and the child to
handle any queued signal; in the child we'd have to erase the queue,
not just turn off queuing.

There are probably cases where this already could happen if the timing
were right.

Unless somebody comes up with a reproducible (even irregularly so) example,
I think you're right that it's more trouble than worth.