zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Expose isearch and suffix regions to widgets.
Date: Sat, 23 Apr 2016 15:33:56 -0700	[thread overview]
Message-ID: <160423153356.ZM6960@torch.brasslantern.com> (raw)
In-Reply-To: <20160423213607.GB1405@tarsus.local2>

On Apr 23,  9:36pm, Daniel Shahaf wrote:
}
} m0viefreak wrote on Sat, Apr 16, 2016 at 18:17:40 +0200:
} > I think ISEARCH_MATCH would be the ideal name, if the matched string was
} > exposed, but I haven't found a simple way to do that.
} 
} Something like the attached, perhaps?  Do you think something like this
} should be added?  (Myself, I'm not sure, since the value would be
} derivable from the three ISEARCHMATCH_* parameters' values.)

My point in suggesting ISEARCH_MATCH was to limit the feature to three
variables with "ISEARCH_" as a prefix.  This was countered with the
expressed desire to follow the "_ACTIVE" suffix pattern instead.  I'm
not particularly invested in this either way, but having *both* the
"_MATCH" and "_ACTIVE" variants is certainly redundant, and having
two different prefixes ("ISEARCH_" and "ISEARCHMATCH_") is annoying.

Other comments:

I will posit that isearch is rather different from YANK/SUFFIX/REGION
in that one might be interested in what the current search pattern is,
as well as what string is matched.

There are two existing variables LASTABORTEDSEARCH and LASTSEARCH which
refer to that search pattern, neither of which uses the "I", so maybe
these new three (or four or five) shouldn't use it either.

Those two variables aren't cleared when you start a new search, they
only change based on the final state of the search.


  reply	other threads:[~2016-04-23 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-13 21:51 m0viefreak
2016-03-21  9:47 ` Peter Stephenson
2016-03-21 16:11   ` Daniel Shahaf
2016-04-10  5:26 ` Bart Schaefer
2016-04-10  5:35   ` Bart Schaefer
2016-04-10 13:10     ` m0viefreak
2016-04-11  6:16       ` Daniel Shahaf
2016-04-11 14:25         ` Bart Schaefer
2016-04-16 16:17           ` m0viefreak
2016-04-23 21:36             ` Daniel Shahaf
2016-04-23 22:33               ` Bart Schaefer [this message]
2016-04-25  8:19                 ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160423153356.ZM6960@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).