From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Infinite loop with "hash ="
Date: Tue, 7 Jun 2016 10:03:29 -0700 [thread overview]
Message-ID: <160607100329.ZM15469@torch.brasslantern.com> (raw)
In-Reply-To: <87fusprngk.fsf@gmail.com>
On Jun 7, 6:08pm, Christian Neukirchen wrote:
}
} Running "hash =" will trigger an infinite loop, even with the check
} currently implemented. (Same for "hash =foo".)
Hrmph, that's pretty silly.
diff --git a/Src/builtin.c b/Src/builtin.c
index 6f07fc6..c2fb81e 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3748,6 +3748,7 @@ bin_hash(char *name, char **argv, Options ops, UNUSED(int func))
if (!(asg = getasg(&argv, NULL))) {
zwarnnam(name, "bad assignment");
returnval = 1;
+ break;
} else if (ASG_VALUEP(asg)) {
if(isset(RESTRICTED)) {
zwarnnam(name, "restricted: %s", asg->value.scalar);
prev parent reply other threads:[~2016-06-07 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 16:08 Christian Neukirchen
2016-06-07 17:03 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160607100329.ZM15469@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).