From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38682-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 28981 invoked by alias); 14 Jun 2016 21:06:20 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38682
Received: (qmail 3689 invoked from network); 14 Jun 2016 21:06:17 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version;
        bh=9lSEjIRAkqqxx83pQY8Xbcs/4eisP7ZZ3i8oupBg8q8=;
        b=NzLrXF41uWrPHnswA5ky2VDHswZe0iaNMQSFtycOWs4ySGLOBVGtFhxAHORxIVSFYk
         on5hZlM4tuR6FGw4V6FhlQvrQZY1z2L7v2+NX8+WShksimeUOBOaBxyq1nZ5zC/TWvTj
         6ULVPBwMgv+ygA0Yvx0jcMHBPLKhrRKk6xWQe8Aw6JF7p95VmsR1uwmzCS02496q8lbm
         ERjYqtzvLnKaZguUeOqz3DZk8O3x8uSQd9HMbkud+/ThAofE1gtiF4g8He9h4okxNNjU
         WZdFSLptWoF4Anm3v9dSjIs9aM22Ovu2Njtp6rQBy6FOG69ZC+pfrvgWSe+oRjG3uJgN
         B0MQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version;
        bh=9lSEjIRAkqqxx83pQY8Xbcs/4eisP7ZZ3i8oupBg8q8=;
        b=LvqeliADTBgwyGTjCpNsY8G6/YZDDRqzBZ3G2KDfxHfOf2DM6Leq46kbS7fA3vk1WF
         jqQoGw51mZuIbuIUIu8m7PcjTsWt0309WqX35flI/TYhBcNToV0/qkL184b3nAKIwMOe
         S6RuNezgPoetpskx5lz80dUZxnmz+6IJyHl1Dw6qeWCumrAbhPNqoZ8Fr4bWkFcs15lM
         Lwj7OAtnpreDaXvB6xUec2xsZ6DHAM3Zs31AmctwtEweAh4aUO5ACE88SO6EzEG58ijG
         XWyxh3HYN+qnzaPWTuGC8phxSdxOkykCZQOtMT10u+McJW7Gjv331fqGJHohHFn2mSoX
         i8XA==
X-Gm-Message-State: ALyK8tIYJT6E57AG2COx3yeDJuhIy0imJuDNKa1yml3C5EDhbo5XorjiL0YUp55U6bmxRw==
X-Received: by 10.98.59.150 with SMTP id w22mr5728055pfj.4.1465938374118;
        Tue, 14 Jun 2016 14:06:14 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160614140634.ZM18279@torch.brasslantern.com>
Date: Tue, 14 Jun 2016 14:06:34 -0700
In-Reply-To: <160614111054.ZM17893@torch.brasslantern.com>
Comments: In reply to Bart Schaefer <schaefer@brasslantern.com>
        "Re: [PATCH] add-zle-hook-widget" (Jun 14, 11:10am)
References: <160612184453.ZM11316@torch.brasslantern.com> 
	<20160613085219.GA23148@tarsus.local2> 
	<160614111054.ZM17893@torch.brasslantern.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: [PATCH] add-zle-hook-widget
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jun 14, 11:10am, Bart Schaefer wrote:
}
} On Jun 13,  8:52am, Daniel Shahaf wrote:
} } What happens when a zle-line-init already exists when add-zle-hook-widget
} } is first called?  I had such a hook and it was simply discarded.  Should
} } add-z-h-w warn that it is overwriting/redefining an existing hook?
} 
} Hmm, how did that happen?  The test for [[ -z "${widgets[$fn]}" ]]

Two thinkos:

(1) I meant [[ -z "${widgets[$hook]}" ]]

(2) but that doesn't stop a *function* named $hook from being replaced,
    which is probably what you meant.

Yes, something should be done about that.