From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: tab completion color inversion
Date: Thu, 7 Jul 2016 10:01:25 -0700 [thread overview]
Message-ID: <160707100125.ZM23567@torch.brasslantern.com> (raw)
In-Reply-To: <49130.1467902941@hydra.kiddle.eu>
[>workers]
On Jul 7, 4:49pm, Oliver Kiddle wrote:
}
} The patch below resets the saved colour first but I'd actually be
} inclined to change the following macro to do the AND before the OR.
}
} #define txtchangeset(T, X, Y)diff((void)(T && (*T |= (X), *T &= ~(Y))))
}
} It might also then be logical to swap the X and Y arguments.
Reactions:
(1) Is this related to "End boldface also ends background color" thread
from back in March?
(2) As I said in that thread, I don't really follow the semantics of
the txtchangep pointer, but AND before OR seems sensible in the macro.
(3) Swapping the arguments would touch a lot of code and make it hard
to compare revisions, so the benefits ought to be carefully weighed.
next parent reply other threads:[~2016-07-07 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACW6SB6sRKdtsbFe_ikp1zqP3YRd9grq-xABMGutu4fRvCqM2A@mail.gmail.com>
[not found] ` <49130.1467902941@hydra.kiddle.eu>
2016-07-07 17:01 ` Bart Schaefer [this message]
2016-07-07 23:21 ` Oliver Kiddle
2016-07-08 17:47 ` Bart Schaefer
2016-07-08 22:00 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160707100125.ZM23567@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).