From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12530 invoked by alias); 17 Jul 2016 19:01:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38872 Received: (qmail 6981 invoked from network); 17 Jul 2016 19:01:53 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f195.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.195):SA:0(0.0/5.0):. Processed in 0.121715 secs); 17 Jul 2016 19:01:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=gQZiSTT+cByrrZldwFm6flH1UtmfoiHu4ei6jCsiUdg=; b=muyt+t8B1GCLqrtBuivVjVtyvGvsa4Y7ajV155HG+U7xcFvHiSOEHJHRZcjgLdqrPi jjP7v2xaXrbbUyBByKrc9ckDP77r122CjBE1VGW5sBTgIGDl5ytMeCpkDjuw4wfTFalo +Ho+VN6Y6KfszbcF70q7P9wF9swjs4J7LOnnWHxnypPIiCD4uqM+//WdHFkVtets877+ DYWgXBS3pPV+1s6uK7AJMr5YLRd6+pW8bNI0CCtSg0uPVDDAXRX6gg1UdUFjIOGRess1 OcDyjrNs9cBpi7PXvxbEQkBEQKvv/t717ypU0RwI51sR1RSJtisqhHxkpv0GU+tg+xyb g7AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=gQZiSTT+cByrrZldwFm6flH1UtmfoiHu4ei6jCsiUdg=; b=Ffgpr7Qyf3w72+OLKuE7faJ9jZsOykJUb0TbDgQH5r397WeVAG+Gc94CO5l10Q2D8a zl6gNh2ehkUxZrG3lgSlA+fzCmDSReBM232YEgL0jF3rewcZrM5bO881VUmwRXigyDLt DEyAzL/PKuo2a6f7a3K/1rEyL/JxFToYt5drj9UHDkwEEEf88sSK3bCjRZd5G2s9sD23 YDzJ8Y3CR2xEaPkrsZPKVKxoU3vui8fwXJVtW2GTFPJAZjQfLrM3VGK4jW+Z/riMombI Kk09wJaAUFWiLtcjvBTgzjKpCbOHVK4w/koeuOkK2duHBVxtF+4AfO79mrLS4D6Z9MrE FC7w== X-Gm-Message-State: ALyK8tL7QkoJIh/Dnpr+TqiYJ6rfA/ofM2cMHQKaGT3sf/c5URAjVtr94q+MOxZCMTXbNA== X-Received: by 10.98.157.12 with SMTP id i12mr40081257pfd.164.1468781302926; Sun, 17 Jul 2016 11:48:22 -0700 (PDT) From: Bart Schaefer Message-Id: <160717114805.ZM1247@torch.brasslantern.com> Date: Sun, 17 Jul 2016 11:48:05 -0700 In-Reply-To: <20160717145933.GA9239@tarsus.local2> Comments: In reply to Daniel Shahaf "Re: add-zle-hook-widget Re: Next release (5.3)" (Jul 17, 2:59pm) References: <20160717145933.GA9239@tarsus.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: "Zsh Hackers' List" Subject: Re: add-zle-hook-widget Re: Next release (5.3) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jul 17, 2:59pm, Daniel Shahaf wrote: } Subject: Re: add-zle-hook-widget Re: Next release (5.3) } } > +*evalautofunc) ;; } > +*loadautofunc) add-zle-hook-widget "$@";; } > +*) [[ -o kshautoload ]] || add-zle-hook-widget "$@";; } } The [[ -o ]] test will be always false because of the 'emulate -L zsh' } at the top, won't it? True, though only applicable if the evalautofunc test fails, which it will on zsh versions from before mid-2010. Could fix this by wrapping the entire body up to just before that "case" in an anonymous sub, but that fails on zsh versions from before mid-2008. OTOH there are other incompatibilities lurking, so that's probably the easiest thing. On a third hand (?), though, a large fraction of files in Functions/ assume "autoload -Uz", use emulate, and don't bother testing ksh-ism. } This hunk should also be applied to bracketed-paste-magic Yep. Was waiting to see if there was feedback. I think I should also move add-zle-hook-widget to Functions/Misc/. All the other files in Functions/Zle/ represent widgets.