From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Incorrect sorting of Polish characters
Date: Thu, 21 Jul 2016 17:38:05 -0700 [thread overview]
Message-ID: <160721173805.ZM31148@torch.brasslantern.com> (raw)
In-Reply-To: <20160720093515.07cedcdc@pwslap01u.europe.root.pri>
On Jul 20, 9:35am, Peter Stephenson wrote:
} Subject: Re: Incorrect sorting of Polish characters
}
} On Tue, 19 Jul 2016 22:05:08 -0700
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > Hm. On a glob of 16794 files it's about 4% slower over 10 trials with
} > the extra pass over the array of matches. I don't suppose there's some
} > way to store the original file name at the time metafication is applied
} > rather than metafying and then unmetafying again?
}
} It already works like that, and it only copies and unmetafies if there's
} a Meta character.
What I meant was (now that I have poked around a bit further), maybe
zreaddir() should be able to return unmetatfied strings on request,
which scanner() could then metafy before calling pattry() and when a
match is found, pass both to insert() ?
Seems wasteful for zreaddir() to unconditionally metafy when the
caller may need the name unmetafied. However, this does mean passing
both strings through a lot of layers, so maybe not worth it for 4%.
The strchr() does shave it down a fraction.
prev parent reply other threads:[~2016-07-22 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 17:17 Michał Bartoszkiewicz
2016-07-16 20:07 ` Bart Schaefer
2016-07-18 9:33 ` Peter Stephenson
2016-07-18 10:17 ` Peter Stephenson
2016-07-20 5:05 ` Bart Schaefer
2016-07-20 8:35 ` Peter Stephenson
2016-07-22 0:38 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160721173805.ZM31148@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).