From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23251 invoked by alias); 23 Jul 2016 20:00:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38926 Received: (qmail 17253 invoked from network); 23 Jul 2016 20:00:29 -0000 X-Qmail-Scanner-Diagnostics: from mail-pa0-f68.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.220.68):SA:0(0.0/5.0):. Processed in 0.111114 secs); 23 Jul 2016 20:00:29 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=C/anqOOvdu7GS6xFyjByrEPRQzzDMMS66XYQQjjPxhg=; b=nVJO9Me0w9Mw95GbZZ9MFWlFPOHrSAQtQbu3GBOILNlrgeNBid4IjrrS/8JwKt2rlK 5MZOK4yRyUACpae6s5WoE0/ogaY8IB9rvZyJVSC/EqQQIRN7yfpSA2886rQB/BI6h9CO Sb/W1d29BVEvczSkVlnYTVltCysES78hACbtKGskILYD6V6ndqm2GLvGj0HXmvJ9m14p i0vDuUS0/qKenrnUI9IqMu7EDrcrzolHMTD1AeuRgUt48mElu8yYefAkE7SPA3ftMEMM v31nrYj5Lbbsv6ookZleROEvvpQVXatlRjcrFFVyX+hOn5re6rWj8E0YYS6BqIwZu0fg hwFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=C/anqOOvdu7GS6xFyjByrEPRQzzDMMS66XYQQjjPxhg=; b=GIdBEZpeLePdwZABkfaDvgitp3QICewX53qkSPoLDsFaGQQutVT3BvEytAiOMbVthQ LsvgmzIa/EzHNJidb+slqLOU+HOODe7CVdfr1IAaZKgwreVkOsETLqvfiTnNPpGqiZ6A JinD90S92V7Z5Th/wyRAAwjW081SeVer5sJ7PpaBY/PVcbJzAvdpCmyXouq0jVRKMo/R kSta36WxYhlKRsRA+0q08Fc+ztiB5irxnwTb6+Obkrl79Oog5BBn9E3p2RJwF6gfrWLe yagCHPxeLK3MC3AbcQwEQHG2vTqUQIMNVs64HChJoWf3qXTW5VGqo38rfJ3G4jVTd7d9 e3BA== X-Gm-Message-State: AEkoouvtVOxZ1ldV+kLqlJ5+h24lyvhb87SaGP6KpS65hXc38iy0gojo3YwyKssGL7RilA== X-Received: by 10.66.156.226 with SMTP id wh2mr17533444pab.116.1469304018912; Sat, 23 Jul 2016 13:00:18 -0700 (PDT) From: Bart Schaefer Message-Id: <160723130059.ZM19333@torch.brasslantern.com> Date: Sat, 23 Jul 2016 13:00:59 -0700 In-Reply-To: <20160723180430.GA22451@tarsus.local2> Comments: In reply to Daniel Shahaf "[PATCH] _describe and literal \n" (Jul 23, 6:04pm) References: <20160723180430.GA22451@tarsus.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] _describe and literal \n MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jul 23, 6:04pm, Daniel Shahaf wrote: } } Gives: } [[[ } % f } bar -- lorem\nipsum } foo -- hello\nworld } ]]] } } Is this fix correct? Boy, that's a tough one. If the embedded newlines mess up something else, like for example menuselect keeping track of lines/columns/cursor, then I'd say this is the closest thing to a correct quick-fix. On the other hand if the extra newlines are handled correctly, then I'd say this fix isn't warranted, and it's up to the caller to decide what is meant when a newline appears in the descriptions. Ideally the newlines would get noticed and the result would be more like [[[ % f bar -- lorem ipsum foo -- hello world ]]] but that seems a tall hill to climb.