From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] New :P history modifier.
Date: Wed, 17 Aug 2016 10:06:14 -0700 [thread overview]
Message-ID: <160817100614.ZM21570@torch.brasslantern.com> (raw)
In-Reply-To: <20160817163141.GB9003@tarsus.local2>
On Aug 17, 4:31pm, Daniel Shahaf wrote:
}
} - xsymlink() is not a drop-in replacement: it tolerates trailing
} non-existing path components. The single callsite in current master
} wouldn't care, though.
Pretty much my point; if there's only one call and they're equivalent
for that instance, why leave the special case?
} > Picking at the docs ...
} >
} > Given that we went to the trouble of hashing it out, it is probably
} > worth noting that :a is intended to result in the path to along which
} > "cd" would change under the default setopts (no_chase_dots),
}
} 38945 made such a change; do you think further changes are needed?
Nah, that's probably good enough.
} > } + "a:absolute path, resolve '..' logically"
} > } + "A:same, then resolve symlinks"
} > } + "P:realpath, resolve '..' physically"
} >
} > I'm not sure "logical" and "physical"
"lexical" and "physical" are probably good enough, given the mnemonic
helpfulness (P -> physical, a -> absolute).
} > The new word modifier ':P' computes the physical path of the argument.
} > it is different from the existing ':a' modifier which does always
} > resolves /before/here/../after to /before/after, and differs from the
} > existing ':A' modifier which resolves symlinks only after here/.. is
} > removed even when /before/here is itself a symbolic link.
}
} What about the "It is recommended [to audit uses of :A and change them
} to :P]" sentence that the original patch had, should it be kept or
} removed?
IMO it can be kept.
--
Barton E. Schaefer
next prev parent reply other threads:[~2016-08-17 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 23:54 Daniel Shahaf
2016-08-17 7:02 ` Bart Schaefer
2016-08-17 16:31 ` Daniel Shahaf
2016-08-17 17:06 ` Bart Schaefer [this message]
2016-08-18 16:55 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160817100614.ZM21570@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).