From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28620 invoked by alias); 17 Aug 2016 17:06:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39053 Received: (qmail 18194 invoked from network); 17 Aug 2016 17:06:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-pa0-f48.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.220.48):SA:0(0.0/5.0):. Processed in 0.143223 secs); 17 Aug 2016 17:06:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=zCIQJEEjs+ZX7dJAlzebFWSoUHJPwOsuQ34ldFKSmPk=; b=Gx6Pz2EMgz+3bHfNi+isvLUqzaF3ENlGON/O+Ou4hRpZb+gK1jBQjr/W9XZFD3Zx/7 y82HQKnexb2BkiBNY7YPqCs+IDGQTy0h7MwnXGeA217Br+8q/82d/U9ZBR8sdkEzhkiF Uqs3thnenGyhIqf0EN9uo1rJHix1JcnbSmvQ8N+Ffv20jhrpOo1SHnM7DMbL8KOOVZSE xfp8LcNKsxb89vQTAOt8FqfABSkIwMLubcDSy1EeOn1yV+X1K/f6H4lQl7k4aoBQZCv1 hyC7EBwdfijldTYt20YRDRxAABk43PmtGKBpYDsgXH8K63ajb+wT8oVe55ouTfMoCPP0 3Nwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=zCIQJEEjs+ZX7dJAlzebFWSoUHJPwOsuQ34ldFKSmPk=; b=UDPN3PHDK3psMoX0EvCmA5/qWw43Zsvv2JxiYpW0HYv2xkUN5LWhKmQcgiCokG7HiF UTt7CQ3TMyrYN+b14eshC9Ix9zgV/IhUX7cNt2tZnoHN17ipawZImx0g6nVginz2ZJGE KFEUaiKuj+sVfSY+/HhjIVf1woPXU87EUqrEGMLGxpVsUY+SNuqAuXokF4TFJOGj593E 90B5J5cO9UJ1s2eKrShYXS/kx7AWegmmAfXTfmHRwyn7Kh8LK2R1We/p4/o/YuP1ICsN nr8W3kxsI4ahx0Ljfq0TzgMpjJs5Gh6miSyvROaswWjzlr/TGsatALLnuk+k8HeDnYiM DBFw== X-Gm-Message-State: AEkooutycggzrZekUtVWQzLpkE+DQkcREuLzFWA6fi8SQEB0eBLk5dUCA4Vy1D1rGWdA6A== X-Received: by 10.66.222.202 with SMTP id qo10mr20435181pac.76.1471453567096; Wed, 17 Aug 2016 10:06:07 -0700 (PDT) From: Bart Schaefer Message-Id: <160817100614.ZM21570@torch.brasslantern.com> Date: Wed, 17 Aug 2016 10:06:14 -0700 In-Reply-To: <20160817163141.GB9003@tarsus.local2> Comments: In reply to Daniel Shahaf "Re: [PATCH] New :P history modifier." (Aug 17, 4:31pm) References: <1471391679-9604-1-git-send-email-danielsh@tarsus.local2> <160817000240.ZM19759@torch.brasslantern.com> <20160817163141.GB9003@tarsus.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] New :P history modifier. MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Aug 17, 4:31pm, Daniel Shahaf wrote: } } - xsymlink() is not a drop-in replacement: it tolerates trailing } non-existing path components. The single callsite in current master } wouldn't care, though. Pretty much my point; if there's only one call and they're equivalent for that instance, why leave the special case? } > Picking at the docs ... } > } > Given that we went to the trouble of hashing it out, it is probably } > worth noting that :a is intended to result in the path to along which } > "cd" would change under the default setopts (no_chase_dots), } } 38945 made such a change; do you think further changes are needed? Nah, that's probably good enough. } > } + "a:absolute path, resolve '..' logically" } > } + "A:same, then resolve symlinks" } > } + "P:realpath, resolve '..' physically" } > } > I'm not sure "logical" and "physical" "lexical" and "physical" are probably good enough, given the mnemonic helpfulness (P -> physical, a -> absolute). } > The new word modifier ':P' computes the physical path of the argument. } > it is different from the existing ':a' modifier which does always } > resolves /before/here/../after to /before/after, and differs from the } > existing ':A' modifier which resolves symlinks only after here/.. is } > removed even when /before/here is itself a symbolic link. } } What about the "It is recommended [to audit uses of :A and change them } to :P]" sentence that the original patch had, should it be kept or } removed? IMO it can be kept. -- Barton E. Schaefer