From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23112 invoked by alias); 25 Aug 2016 17:06:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39104 Received: (qmail 14211 invoked from network); 25 Aug 2016 17:06:08 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f177.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.177):SA:0(0.0/5.0):. Processed in 0.743294 secs); 25 Aug 2016 17:06:08 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=zp2KKQo7r6roEhVy5XL2wVpGMc4HB0Ra6rOBB+kptBw=; b=uNKivjJYfiUQoQcgq0f/eqNvoSyJBrhkAXDG83Ty5qlSFUM6x8NwwUhF8lf5IoAHnY cWFgoDNqv4Av9v+O2KHGymwL0N5LvFrrBxOs/++fKFYFfTHGdgvck+fV8IxNIQKKRMQY IPp7w5FmBdy7JuoDCuzPUVgGV2fg9UiSGW0TfbohVsZhZ09vzk9aVsL3ZO0DtDjddAsF vHj+B8XHcir0APOvjlctI4/lCAN+2xFLz+OvL1ZbQtTiLWKAXjm3Qur8gcTDqKURaZ6c MI5iNeNlM0swF8MBtNOcwcNwudJe98ZgDDp8aBRUC0YwUYoPcaM6+sNgTKfTe82sTu5Z A+tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=zp2KKQo7r6roEhVy5XL2wVpGMc4HB0Ra6rOBB+kptBw=; b=PdtVJxzkM+HNbRk5hq+mmS+g4nEWMxyhfkJTCW0QeZ7tH/LB4Wa6rkJJCeSeyiaI35 6hoyKVDsY4oFA93dBGSxgYp19tWL2sb8wW9dKCvr1Pf98MxWPGjNb2MxDOyUo7vJ6lGJ Q/myhNfZUT1uZUO1JjWpXNOeAgaAX2bpcuMn4pkmvlMZ1F3pTueFyzWAQbqqBQOcqqiw wMMzXLnCXm8g1GqTU27HD0V3JirMb50v2yov78C7LPuMLHSd8HAozFrUI7sRS2kGWZd4 6y60LOM5t/5QZd2NaYjhcqZMZHATvJuTUovX6GGvPPxm/bbbD20+d37XCWwKj7lQ+Kie wH+A== X-Gm-Message-State: AE9vXwOWLNqgcPTBcITg/KJ3lijk5r+uGEckYmi+iMGPo5Bwy6PLcLI7l+U+uJelw3ZQlA== X-Received: by 10.98.196.138 with SMTP id h10mr18081760pfk.60.1472144318161; Thu, 25 Aug 2016 09:58:38 -0700 (PDT) From: Bart Schaefer Message-Id: <160825095900.ZM16562@torch.brasslantern.com> Date: Thu, 25 Aug 2016 09:59:00 -0700 In-Reply-To: <20160824205849.GA11450@fujitsu.shahaf.local2> Comments: In reply to Daniel Shahaf "Running 'type' causes false positive hashed command completion" (Aug 24, 8:58pm) References: <20160824205849.GA11450@fujitsu.shahaf.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Running 'type' causes false positive hashed command completion MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Aug 24, 8:58pm, Daniel Shahaf wrote: } Subject: Running 'type' causes false positive hashed command completion } } $ zsh -f } % cd $(mtemp -d) } % touch sudofoo; chmod +x $_ } % ./sudo } } % ./sudofoo <^C> } % type -w ./sudo } ./sudo: none } % ./sudo } ./sudo sudofoo* } } That's wrong because ./sudo does not exist. This seems pretty obvious: diff --git a/Src/exec.c b/Src/exec.c index ea9214d..9b24d38 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -772,7 +772,7 @@ findcmd(char *arg0, int docopy) Cmdnam cn; cn = (Cmdnam) cmdnamtab->getnode(cmdnamtab, arg0); - if (!cn && isset(HASHCMDS)) + if (!cn && isset(HASHCMDS) && !isrelative(arg0)) cn = hashcmd(arg0, path); if ((int) strlen(arg0) > PATH_MAX) return NULL; Can anyone think of a valid case which that breaks? The doc (under the PATH_DIRS option) even says "Commands explicitly beginning with `/', `./' or `../' are not subject to the path search."