From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39204-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 8491 invoked by alias); 7 Sep 2016 05:57:45 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39204
Received: (qmail 25087 invoked from network); 7 Sep 2016 05:57:45 -0000
X-Qmail-Scanner-Diagnostics: from mail-pf0-f194.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.192.194):SA:0(0.0/5.0):. 
 Processed in 0.741906 secs); 07 Sep 2016 05:57:45 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version;
        bh=EcMVdNUa/8Hep9iRgvd7a17Bhxi6S7ZZLKJXVYK+t6M=;
        b=A7gDVMhEJSWuW7dhe0x1TclpAhyUlTqLt0P8do11QnD3LDuXDUH6VJK8Tyk9X4tkmV
         T6LCD4kQUAM+u6L7GQxrtT3KiChtGq08aw0bT9HK9P4DBKug/4f5bAxVLWociElPWAKt
         BLNT7ZbJ8oZ6wFjK2Tt47ctaOatdNh9xrqCHm1St4MtaK4+FeT/18I8NXhRRBc+Rw4bI
         MdkMqX38J+bgLqsERVw90qA+DBxp6tL3H7TGBJRp0ICFnHZnaZopQ9i93xOKgCLgXXNX
         KXkPqYsEgL2TNwVxvM/fAMqK5rACYhKy+ws7Ry4GLW3ZqfvvUDwfGQ+BfZYJetgpB8/X
         zO9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version;
        bh=EcMVdNUa/8Hep9iRgvd7a17Bhxi6S7ZZLKJXVYK+t6M=;
        b=CScIe0xAf1EavnR6vu8pCcPz5VfLEnIOf5xp23DQgiHfQFltsBiaVxbOfjW7iMbCPt
         sqrqK2Sff6od41Z+ZTRJItcrZiHKjaW9nFIEMm7Ge9VY7rqdkMK9r3duoSIzu/2kr5gV
         /q8PFJ2FeEWUqbuRaOfWLwh2d6k8B7OiHsSGUdUrnPBoyHbAKKsjFt6g9PI3vH9nnUep
         rz7HytqQhT0xhsUPCMufeXKuTOd2spqArXwl/sAht7GBNBvdrDBSlNrX26xZiyFn53fi
         /q/zCanmgQDU7NtZ4flqteNN09D0W7CgXTzGfzBMR079te5ADlm/vDQAtirKv0L14GZe
         2HRg==
X-Gm-Message-State: AE9vXwN+IMbd03ozbFqgnXZ6yWgzQTh72rKtgh3/ExmCN9GiaRXOlSgounpFEe39ulzSlA==
X-Received: by 10.98.70.8 with SMTP id t8mr79910802pfa.36.1473227858722;
        Tue, 06 Sep 2016 22:57:38 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160906225736.ZM11304@torch.brasslantern.com>
Date: Tue, 6 Sep 2016 22:57:36 -0700
In-Reply-To: <20160903210630.54164-1-tgyurci@gmail.com>
Comments: In reply to Teubel Gyorgy <tgyurci@gmail.com>
        "[PATCH] Fix ENV handling in sh/ksh emulation" (Sep  3, 11:06pm)
References: <20160903210630.54164-1-tgyurci@gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Fix ENV handling in sh/ksh emulation
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Aside that this patch also included two other hunks changing
isset(INTERACTIVE) to the equivalent "interact" macro instead.

This makes them all the same in init.c, except for one use of
unset(INTERACTIVE) instead of !interact.  However, other files
don't seem to be consistent about making use of this macro,
nor even about whether unset() vs. !isset() is chosen.

I'm not suggesting we go to any special effort to clean this up,
but I'd rather not sneak this kind of thing into unrelated diffs
(at least, not without mentioning it) because, along with things
like whitespace clean-up, it makes it difficult to tell from a
delta what changes are semantically meaningful.