From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19994 invoked by alias); 7 Sep 2016 06:39:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39206 Received: (qmail 20313 invoked from network); 7 Sep 2016 06:39:08 -0000 X-Qmail-Scanner-Diagnostics: from mail-pa0-f49.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.220.49):SA:0(0.0/5.0):. Processed in 0.1405 secs); 07 Sep 2016 06:39:08 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=fmdtTIK0qt8PkVr0uJNylip1K5G39oMSIkjhsIWgH80=; b=TM7CDVY85vD+hdCeTx1AHquLhOhEQW/eMd0A1qQa5antn1xQFi1QfsOJV7q3e7CnHS +aRG+YwH7W51dRa8YAyqlYJCNhsF8wTU5bmq0F0IDNjpnOHl/53PNblDspnfAYaEQ0GJ T8BGi9PYhhdCaF2BQIX5N1ju9pj7D6Id6ScWyYgAPOQUs7vjq3nMpaNBJby3K6JWBPjJ ebkBNAIHHMfztuebhUWP7u+pAS19tKfbURhvFuaDTo+Z4TlzR13khTBE/DXGoKb/hGFu VsBU6phYwZ2INbGXN3pqD0FsSg4ky4M1EwIfWdTlxM9wrvI37loUQrW5r706A1PE7bY2 QLtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=fmdtTIK0qt8PkVr0uJNylip1K5G39oMSIkjhsIWgH80=; b=YJOV/ythi+Q7zU/7I9riHPKBkaGkZpOpfRsd2zM54vSBStCusIWUEVuaYZE828pPgB r+kpMP6og8XCJJOZzFXqBqUA6jbzXgwSIqn+sKnrJNs4wTgOlPdisWbOp2IU2j37xDfu P63uPcCQ1JVquQkdzbWVN6IU9z9PZ3Q4x9MfYlFjq1Ox5L3TcWaTJ0U08CqtvOhOraec I6JIVXi6TxUbYHM4Gvrt5nYq9JZZM/k3NxieEMoBV0L/JAFGNVexHq0DeAeZbo37FIXV IWmH8c8OaqusvhsugzEd6QEXlhgosqr65P4rxuodO6kAJCT3i8JJv/ro5wDdCWloLodA 689w== X-Gm-Message-State: AE9vXwNSqOOgZ9BcWFyO1MO5FS/mVYH2AJ6uBedavizjyzsa39zYwd0Z3yISIyRUZc3VOQ== X-Received: by 10.66.88.135 with SMTP id bg7mr8053952pab.107.1473230343621; Tue, 06 Sep 2016 23:39:03 -0700 (PDT) From: Bart Schaefer Message-Id: <160906233901.ZM11422@torch.brasslantern.com> Date: Tue, 6 Sep 2016 23:39:01 -0700 In-Reply-To: <20160904040142.GA5216@fujitsu.shahaf.local2> Comments: In reply to Daniel Shahaf "Re: [PATCH] _virsh (Was: Re: zsh virsh completion)" (Sep 4, 4:01am) References: <8eb6dce0-50d7-5ab2-503a-194c1de2e45d@redhat.com> <20160713045957.GA3893@tarsus.local2> <9968da53-c1fd-fa2a-f30c-c74f884d2478@redhat.com> <20160720065832.GA28939@tarsus.local2> <699166a0-b0f0-452c-2561-b7e3cc952062@redhat.com> <25001.1469117569@hydra.kiddle.eu> <20160722071927.GG2521@tarsus.local2> <12554.1472678120@hydra.kiddle.eu> <20160902052342.GA8514@fujitsu.shahaf.local2> <66037.1472828529@hydra.kiddle.eu> <20160904040142.GA5216@fujitsu.shahaf.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] _virsh (Was: Re: zsh virsh completion) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Sep 4, 4:01am, Daniel Shahaf wrote: } } Perhaps using sudo should be opt-in on the part of the user; that is: } when gain-privileges is unset, either behave as though it's set to } false, or perhaps prompt the user (via the minibuffer?) for permission } to use sudo. (And cache the user's reply for next time?) } } Just thinking out loud here. I haven't been paying a whole lot of attention to this thread because Oliver seemed to have it pretty well surrounded, but my two cents: I would prefer that we never implicitly call 'sudo'; rather, that it be explictly referenced by the user in a zstyle whether or not it's already on the command line. There's an admittedly somewhat arbitrary line between a completion being helpful enough, and it venturing into places it has no business going in an effort to present perfect knowledge. Sometimes perfect knowledge isn't worth the effort or the side-effects. (A lot of the "remote" completions are bumping along this line as well.) However, I also think prompting during completion (except in the form of the menu-ing variations) is likely to cause mistakes.