zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Off-by-one with select-*-shell-word text object?
Date: Fri, 16 Sep 2016 10:21:37 -0700	[thread overview]
Message-ID: <160916102137.ZM11290@torch.brasslantern.com> (raw)

Noticed during recent zsh-users thread:

torch% quote-this-word() { zle select-in-shell-word; zle quote-region }
torch% zle -N quote-this-word
torch% bindkey "''" quote-this-word
torch% echo foo''
torch% echo' foo'

Note the left-quote has now included the space preceding the word.  I at
first suspected another vi-mode vs. emacs-mode difference, but:

torch% bindkey -v "''" quote-this-word
torch% bindkey -v
torch% echo foo''
torch% echo' foo'

Same effect for select-a-shell-word.  The right thing happens if I avoid
the *-shell-word variant:

torch% quote-this-word() { zle select-in-word; zle quote-region }
torch% echo foo''
torch% echo 'foo'

If including the preceding space is intentional, it should be mentioned
in the documentation.


             reply	other threads:[~2016-09-16 17:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 17:21 Bart Schaefer [this message]
2016-09-16 20:47 ` Oliver Kiddle
2016-09-16 21:22   ` Bart Schaefer
2016-09-16 23:30     ` Oliver Kiddle
2016-09-17  3:02       ` Bart Schaefer
2016-09-17  7:42         ` Daniel Shahaf
2016-09-17 14:29           ` Bart Schaefer
2016-09-19  7:00             ` Daniel Shahaf
2016-09-19 10:01               ` Oliver Kiddle
2016-09-19 15:19                 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160916102137.ZM11290@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).