From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2710 invoked by alias); 17 Sep 2016 14:29:10 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39377 Received: (qmail 13992 invoked from network); 17 Sep 2016 14:29:10 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.175):SA:0(0.0/5.0):. Processed in 0.184476 secs); 17 Sep 2016 14:29:10 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=Uhwjs0Q45GOJAKzB6J7MLOEPMIOvrft/qB+vcvzZz60=; b=awXcFPVO6bpjM739CiVSRUcxP2Yk3o4wWhB/9s4YIujlnK0thCaPsVVWybggY38EK1 W6+iRorxMzmSJSh1eCgesr1Aouq9RAwdj7NTP+LnAWjkA/3v7gUy4Zs7VGeSXt/DvVQR k0WeXQVGumNhHsCsEt+HeoQVdfMdOC9L2UN6uWaXSQnGivSl39xNjB8ORWTJw+CgkO29 xWZJWgnLWYLAj7QnNjkUAXVPm19z0JcScR8ps6haE85gXKOD0dJywe2CiC2rX0VKRA8E D53mnc6IOCgVQ4wBPGx5j5C6OYnr/+BmAQ+L4XU+o6fZ3s41Up0UrAZ0JSEgoD8KevUC nGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=Uhwjs0Q45GOJAKzB6J7MLOEPMIOvrft/qB+vcvzZz60=; b=Xf/wgHQRnBPv9w0ElZ5QEvdsqqQEjwBAFjYhvWuY8WabPqMx68YyAjFlelmXm7nyvC OVW8WhX0e7XEQ8A8CBe8CMme4lyEHxvAnyTJqwtpB+xb3mKL11tpP3EInDkEnzOyYYJ8 3fEVUihxKSQidlOe+sfOHS/uXCIoAHTU6WBensDssxKj2w75cCV0d3x5NjcL75jTyz8l Pj6YXcETIjhZ2jqWhyZmmimomhzJAeyrSxIEawRuSFYFW4phlJRmSYSwToWcu2/NRHGa PtGnn18H7QqgYxotkp5szPNlkqBXfh+fVrTQW0WQlyDS+5w8w7tkj6y0lY8ScQIZSDM9 T6aA== X-Gm-Message-State: AE9vXwP4nriOrEDOSTDs52woVIOCQX2MmlxqA/YaWYO9Wydv4biButo/9qES+vvR9Nd5sA== X-Received: by 10.98.93.85 with SMTP id r82mr17956908pfb.168.1474122541360; Sat, 17 Sep 2016 07:29:01 -0700 (PDT) From: Bart Schaefer Message-Id: <160917072918.ZM29255@torch.brasslantern.com> Date: Sat, 17 Sep 2016 07:29:18 -0700 In-Reply-To: <20160917074259.GA26221@fujitsu.shahaf.local2> Comments: In reply to Daniel Shahaf "Re: Off-by-one with select-*-shell-word text object?" (Sep 17, 7:42am) References: <160916102137.ZM11290@torch.brasslantern.com> <76020.1474058827@hydra.kiddle.eu> <160916142248.ZM26196@torch.brasslantern.com> <10734.1474068633@hydra.kiddle.eu> <160916200205.ZM27241@torch.brasslantern.com> <20160917074259.GA26221@fujitsu.shahaf.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Off-by-one with select-*-shell-word text object? MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Sep 17, 7:42am, Daniel Shahaf wrote: } } I think it would be cleaner to invent a new bitmask flag and set it on } the affected widgets (select-*-word, run-help, etc) than to overload } WIDGET_INT for this purpose. It's not overloading WIDGET_INT, it's overloading ZLE_VIOPER - because those are the only cases of builtins that want the opposite case (point to the caller). Testing WIDGET_INT is only necessary because the sense of setbindk is reversed from the sense of ZLE_VIOPER. } Whether a widget is implemented in C or in shell has no bearing on } whether it assumes that $WIDGET points to itself. At the moment that's not true; a widget implemented in shell can never safely assume that $WIDGET points to itself.