From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Is "command" working right, yet?
Date: Sun, 25 Sep 2016 20:13:28 -0700 [thread overview]
Message-ID: <160925201328.ZM24563@torch.brasslantern.com> (raw)
In-Reply-To: <f8ffd815-f32d-c551-2fad-c939970927d3@inlv.org>
On Sep 26, 12:31am, Martijn Dekker wrote:
}
} The culprit seems to be the simplistic option parsing code starting at
} line 2664 in Src/exec.c (current git, e35dcae):
}
} Sure enough, it looks if there's one option and if there is, it happily
} ignores the rest. Combined options like -pV also aren't supported.
Not exactly. That whole thing is in a "while" loop, so as long as -p
and -v and/or -V are in separate words I think the expectation was
that it would loop around and discover the next one .. but if -p is
first, it doesn't loop, and if -v or -V is first then -p is rejected
because it's not [and can't be, see below] listed in the value of
"commandbn" [exec.c 209].
} I don't understand nearly enough about the zsh codebase to know why this
} routine does its own option parsing rather than calling some common
} option parsing function, so I can't offer suggestions for improvement
It's because "command" is a sort-of keyword instead of a builtin, so it
doesn't go through the regular builtin dispatch where the common option
parsing lives. Originally zsh's "command" prefix didn't accept any
options, so this parsing was bolted on bit by bit as POSIX defined them.
A complication is that "command -v" is defined in terms of bin_whence(),
and "whence" has a -p option that means something different.
next prev parent reply other threads:[~2016-09-26 3:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 0:37 Bart Schaefer
2016-02-07 15:24 ` Martijn Dekker
2016-09-25 23:31 ` Martijn Dekker
2016-09-26 3:13 ` Bart Schaefer [this message]
2016-09-26 10:56 ` Martijn Dekker
2016-09-26 17:02 ` Bart Schaefer
2016-09-27 10:08 ` Peter Stephenson
2016-09-27 12:15 ` Martijn Dekker
2016-09-28 10:30 ` Peter Stephenson
2016-09-28 18:37 ` Martijn Dekker
2016-09-29 8:55 ` Peter Stephenson
2016-10-11 13:40 ` Martijn Dekker
2016-10-11 13:56 ` Peter Stephenson
2016-10-11 16:20 ` Martijn Dekker
2016-10-20 12:44 ` Peter Stephenson
2016-10-20 13:06 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160925201328.ZM24563@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).