From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9346 invoked by alias); 26 Sep 2016 16:33:31 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39446 Received: (qmail 10945 invoked from network); 26 Sep 2016 16:33:30 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f171.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.171):SA:0(0.0/5.0):. Processed in 0.132404 secs); 26 Sep 2016 16:33:30 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=0qCFhtBkDgGu4OhoBERWH/EOQPcBJdPio/0/TpX9jVw=; b=1LeMPfMEcetfWYo//Ml2TYQpfW+jzymalPvZa8nfm8pBHKWOVfyK/pdvMRbyt6xkxv FmZszPaYZZtFTpD5jCK7nAeXV/6a6NoyOpOTZz6IxzQEXgiuB0WJ0dpnFawrFdlCza8F 8RkI3F0VWveCYlkvTN9FnGmLrDPA034buF/WQRSSWolT0Jk+1VQc69ELVOpe1DgSRiah r2d2QsSH3jZsG7x9HtXjfJUE8II/XuAnlK3SxT4c/6rw2z1ZMKd/zzJfjuPhKbQ+tKdp 4F5UHIa+88vaF5AZk1KDxlFk+TwcfDH6zrbcgf/H3mDGDUHh8ZQoENb7Fu5pVp04n7Zs 6w8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=0qCFhtBkDgGu4OhoBERWH/EOQPcBJdPio/0/TpX9jVw=; b=JNetFrKJeNvtmueuJvDyoSd5BrjKnc95TdQFlBqrlPnvK4WwUmSgv1/oWk1kRsmKng 4AHdWeKkGavGuh4jG3gl6kI7S2pIBSRc1NJ4HMEZC5C/7AzNvntawW8iGSokLntDnzmR Uk2Sqive/0eRdVaYVgCYb5y3GPnSwkQEOUY82+jDz9r69tk0G48fT/Iw+MkUWfZGShv1 ww1Kmi2EviGtDLvmJD3Inyz53tFzX8oSZfYpIGE/erid9m7P0k7fYZB6kGQmT9ukb0q6 Py03yynZE2F3nJ4i5Oi/4Qk6l4KAONfIpAQaDc+Lc8ISJlMp9AEX3JdUHgDCvFMLp9mf a3cA== X-Gm-Message-State: AE9vXwOnTXke1S/+gFeBhC64VgVlgV5rde4bfHV+G82OcgPM3d56ytfbbIjczWBS8wfuHA== X-Received: by 10.98.55.71 with SMTP id e68mr38061645pfa.147.1474907605589; Mon, 26 Sep 2016 09:33:25 -0700 (PDT) From: Bart Schaefer Message-Id: <160926093335.ZM27240@torch.brasslantern.com> Date: Mon, 26 Sep 2016 09:33:35 -0700 In-Reply-To: <20160926122051.17a8bebf@pwslap01u.europe.root.pri> Comments: In reply to Peter Stephenson "Re: struct job.other (was Re: Bug related to stdin/always/jobcontrol)" (Sep 26, 12:20pm) References: <87r392jgd0.fsf@juno.home.vuxu.org> <20160905164207.4630643b@pwslap01u.europe.root.pri> <20160914183105.69862fa9@pwslap01u.europe.root.pri> <20160914223553.3173c8ca@ntlworld.com> <20160922115921.GA3613@fujitsu.shahaf.local2> <160922093838.ZM7266@torch.brasslantern.com> <160922181847.ZM22524@torch.brasslantern.com> <20160925153924.7e741ffc@ntlworld.com> <160925155436.ZM23968@torch.brasslantern.com> <20160926122051.17a8bebf@pwslap01u.europe.root.pri> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: struct job.other (was Re: Bug related to stdin/always/jobcontrol) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Sep 26, 12:20pm, Peter Stephenson wrote: } Subject: Re: struct job.other (was Re: Bug related to stdin/always/jobcont } } On Sun, 25 Sep 2016 15:54:36 -0700 } Bart Schaefer wrote: } > - jn->other = pid; } > + jn->other = list_pipe_pid; /* see zsh.h */ } } That's OK; I assume there's no race where list_pipe_pid is set to } something else since signals are blocked. If there is such a race, then list_pipe_job is also going to be wrong in all of the surrounding lines, so I think the above is at least not more broken.