From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: _dispatch (was Re: PATCH: [for consideration] TMPSUFFIX)
Date: Wed, 28 Sep 2016 11:49:17 -0700 [thread overview]
Message-ID: <160928114917.ZM32186@torch.brasslantern.com> (raw)
In-Reply-To: <20160928102417.GA2729@fujitsu.shahaf.local2>
On Sep 28, 10:24am, Daniel Shahaf wrote:
} Subject: Re: PATCH: [for consideration] TMPSUFFIX
}
} Bart Schaefer wrote on Tue, Sep 27, 2016 at 12:20:50 -0700:
} > there was not that too much code was aborted, rather that because of a
} > surrounding use of "eval" not *enough* code was aborted; a scripting
} > error.
}
} What can we do to cause enough code to be aborted in that case? Perhaps
} something like the following:
}
} + {
} + eval "$comp" && ret=0
} + } always {
} + if (( TRY_BLOCK_ERROR )); then
} + ... throw the exception ...
} + fi
} + }
Sadly, that won't do it either -- TRY_BLOCK_ERROR is not set:
[[[
torch% comp=': ${:}'
torch% { eval "$comp" && print OK } always { print $TRY_BLOCK_ERROR }
zsh: unrecognized modifier
0
torch% print $?
1
torch% comp=': *(#q)(#q)'
torch% { eval "$comp" && echo OK } always { print $TRY_BLOCK_ERROR }
zsh: unknown file attribute: #
0
]]]
The eval captures everything and turns it into nonzero exit status.
The eval is there (and in two other places in _dispatch) because one
can pass a command line as the first argument of compadd:
compdef 'compadd *' f
There might be another way to permit that without eval'ing, but it
would be convoluted.
next prev parent reply other threads:[~2016-09-28 18:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 22:51 PATCH: [for consideration] TMPSUFFIX Bart Schaefer
2016-09-26 7:25 ` Daniel Shahaf
2016-09-26 16:19 ` Bart Schaefer
2016-09-27 7:00 ` Daniel Shahaf
2016-09-27 19:20 ` Bart Schaefer
2016-09-28 10:24 ` Daniel Shahaf
2016-09-28 18:49 ` Bart Schaefer [this message]
2016-09-29 6:39 ` _dispatch (was Re: PATCH: [for consideration] TMPSUFFIX) Daniel Shahaf
2016-09-29 7:30 ` Bart Schaefer
2016-09-30 7:03 ` Daniel Shahaf
2016-09-30 21:53 ` Bart Schaefer
2016-09-28 6:09 ` PATCH: [for consideration] TMPSUFFIX Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160928114917.ZM32186@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).