From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6532 invoked by alias); 3 Oct 2016 16:33:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39550 Received: (qmail 20683 invoked from network); 3 Oct 2016 16:33:02 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f194.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.194):SA:0(0.0/5.0):. Processed in 0.128248 secs); 03 Oct 2016 16:33:02 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=xdbLeECtsB0NMFrRoUvRKS8RKCFNjYrWPN7E2Ymss4Y=; b=oBlSNGmxLscwFNUD2Isax3DbLT32Ci39zkvzUA79B7cGGK7npetv8O41m8fKNd/14y E8+Cp5LMBJVwWTmcqz/Lpk8c7t+kou82WEOD6c0uqwFALP/z1J6YK3zKZApuVzOTQZ/N WYg2d8s9r0Vvay7F2AE9wIuVMnbuTHxbpW5fpCsnie3zFT6ucxZAAMWODlHtevfSUzvg ZNOOSAR3PmjVYGbWHbtvOqSAvxNjQJHsDGiDcNn4tkC0MIeOWcDzoBOzwUDhrX7ogheO OIs+y+DvNfbviAhIN2jiXz28IhaxXLF3GbhcUdp0GpynzLsemsaTjgm1wr3Kd2yT1yOO VPqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=xdbLeECtsB0NMFrRoUvRKS8RKCFNjYrWPN7E2Ymss4Y=; b=ZiSNbkQyRmUry6wM4BiT6GzEdqiEbOGwR6FFyVWGqRjsIQATI1Lwh28dXbtm6LAK3M 8vC8EKrvlDx/+VPkrOMJLwqQ4UK5ZAABPJTGvb0g2cPPxq3UpPAKWtQwgPl0++LWfA5p P/QJwE28UdKtcQJzqBRkKNaHgMhYTm0ggr9hGkmzr6ONPQjsampgVMXSd81/rIoURsFi TbHn8BMLkyedrtivpruLK1E1ivlP6kgcvK0KvxK+46aWfkTQoa2gvkf3bC1ISFn+4iKw N2nPjBbrMrQviywbqN5QV6MfxgSnxMjkOLPAQQI2O/HTb5csZvfGCeDzqg37ajWFPpn2 jIiQ== X-Gm-Message-State: AA6/9Rn+A8s6WLpPpSi4ViFFBvxJSgtxZ6kb5Y29bECYbUE6jDgz6Dcnh6sUtIExh2EBJg== X-Received: by 10.98.153.149 with SMTP id t21mr4724223pfk.28.1475512379047; Mon, 03 Oct 2016 09:32:59 -0700 (PDT) From: Bart Schaefer Message-Id: <161003093323.ZM8230@torch.brasslantern.com> Date: Mon, 3 Oct 2016 09:33:23 -0700 In-Reply-To: <161002162145.ZM22574@torch.brasslantern.com> Comments: In reply to Bart Schaefer "Re: [BUG] queueing_enabled grows infinitely when in .recursive-edit" (Oct 2, 4:21pm) References: <161002162145.ZM22574@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: Zsh hackers list Subject: Re: [BUG] queueing_enabled grows infinitely when in .recursive-edit MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Oct 2, 4:21pm, Bart Schaefer wrote: } } The second is that zlecore() expects to be entered with the signal } queue disabled, but zle widgets are called with queueing enabled, so } recursiveedit() needs save/zero/restore the queue level around the } call to zlecore(). Here's the patch for this. Unchanged from 39543, but reposting because I explicitly said 39543 was not for commit. diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c index 0b3b1fc..09581b5 100644 --- a/Src/Zle/zle_main.c +++ b/Src/Zle/zle_main.c @@ -1868,11 +1868,17 @@ int recursiveedit(UNUSED(char **args)) { int locerror; + int q = queue_signal_level(); + + /* zlecore() expects to be entered with signal queue disabled */ + dont_queue_signals(); redrawhook(); zrefresh(); zlecore(); + restore_queue_signals(q); + locerror = errflag ? 1 : 0; errflag = done = eofsent = 0; -- Barton E. Schaefer