zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: zsh generates invalid UTF-8 encoding in the history
Date: Fri, 7 Oct 2016 10:01:37 -0700	[thread overview]
Message-ID: <161007100137.ZM19673@torch.brasslantern.com> (raw)
In-Reply-To: <20161007085709.GA7369@zira.vinc17.org>

On Oct 7, 10:57am, Vincent Lefevre wrote:
} Subject: Re: zsh generates invalid UTF-8 encoding in the history
}
} Thanks. Note that it is not clear in the man page whether the
} least recent starts at 0 or at 1. And when -r is used, whether
} one should use <most recent> <least recent> or the reverse.

Indeed, the use of "first last" in the doc is a bit confusing, and
so is the interpretation of the numbers by the command.  It's always
most then least recent; but since negative numbers count backwards
from the most recent (largest number) and the default behavior is
described in terms of using negative offsets, it can be confusing.
 
} And how can one cleanly append history lines to a history file?
} I was using "cat some_file >> ~/.zhistory", which seems to work,

It'll work as long as there are no 0x83 bytes in some_file.

To be completely safe, you need to do something like this:

  # Pass input file as $1, output as $2
  append_plain_file_to_history_file() {
      emulate -LR zsh
      local -a entries

      # Implementation issue:  read -r ignores backslash-newline
      # folding, but without -r embedded backslashes are stripped,
      # which seems a bigger problem.  Fix up $entries later.

      IFS=$'\n' read -r -d '' -A entries <$1
      (( $#entries )) || return

      # Must supply a file name here to set HISTSIZE and SAVEHIST
      fc -pa /dev/null $#entries $(( SAVEHIST + $#entries ))

      while (( $#entries )); do
          if [[ "$entries[1]" == *\\ ]]; then
              entries[1,2]=( ${entries[1]%\\}$'\n'${entries[2]} )
          else
              print -S $entries[1]
              shift 1 entries
          fi
      done
      fc -A ${2:-$HISTFILE}

      # Reset SAVEHIST to avoid attempting to lock /dev/null
      SAVEHIST=0	# fc -p makes this implicitly local
  }


  reply	other threads:[~2016-10-07 17:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 11:48 Vincent Lefevre
2016-10-05 12:41 ` Mikael Magnusson
2016-10-06 18:31   ` Bart Schaefer
2016-10-07  8:57     ` Vincent Lefevre
2016-10-07 17:01       ` Bart Schaefer [this message]
2017-11-29 15:46         ` Vincent Lefevre
2016-10-05 17:25 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161007100137.ZM19673@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).