From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: zsh/complist colours improperly handle multibyte characters
Date: Sun, 23 Oct 2016 11:23:58 -0700 [thread overview]
Message-ID: <161023112358.ZM3708@torch.brasslantern.com> (raw)
In-Reply-To: <20161023183048.3b6d21bb@ntlworld.com>
On Oct 23, 6:30pm, Peter Stephenson wrote:
}
} So something like this might be better?
Yes, this appears to solve the issue, at least for multibyte characters
that take up only one screen column (as you noted).
} This is counting characters properly, but not taking into account the
} width of the character may be greater than 1. As the outer loop is
} assuming one position per character I don't know how to fix that
Looks like doiscol() would need to have the character width passed down
to it to correctly manipulate the color position arrays, and then both
i += chrwid and cc += chrwid or something like that.
As long as sendpos[] and curiscols[] don't change color in the middle
of a multi-column character I think the output part should be OK ...
but I'm not certain, either.
next prev parent reply other threads:[~2016-10-23 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161021011017eucas1p1d1fceae920242e69b4426bc41cb3c064@eucas1p1.samsung.com>
2016-10-21 1:09 ` Danielle McLean
2016-10-21 4:07 ` Bart Schaefer
2016-10-23 17:30 ` Peter Stephenson
2016-10-23 18:23 ` Bart Schaefer [this message]
[not found] ` <20161023184641.4549e10a@ntlworld.com>
[not found] ` <161023105652.ZM3309@torch.brasslantern.com>
2016-10-23 18:59 ` Peter Stephenson
2016-10-23 19:34 ` Bart Schaefer
2016-10-25 10:44 ` Peter Stephenson
2016-10-25 15:59 ` Bart Schaefer
2016-10-25 16:05 ` Peter Stephenson
2016-10-21 8:33 ` Peter Stephenson
2016-10-21 15:48 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161023112358.ZM3708@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).