zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: Bug: cd auto-completion of .. fails with parentheses in directory name
Date: Sat, 29 Oct 2016 12:44:12 -0700	[thread overview]
Message-ID: <161029124412.ZM17234@torch.brasslantern.com> (raw)
In-Reply-To: <20161029193943.7e2ed791@ntlworld.com>

On Oct 29,  7:39pm, Peter Stephenson wrote:
} Subject: Re: Bug: cd auto-completion of .. fails with parentheses in direc
}
} On Sat, 29 Oct 2016 18:06:32 +0000
} Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
} > The following fixes it without breaking the original case; however, the
} > comment is a Sven original so I'm a bit wary of contravening it.
} 
} That's a "my goodness, is that the time?" if ever I saw it.

My intuition would be that the line Daniel commented out was there in
the first place because the quoting that was added in the compfiles
internals was not previously present.  The fact that the end result
is double-backslashing of some of the special characters would tend
to support this notion.

I'd lean toward committing Daniel's _path_files one-line change.

} The first step to getting this under control is probably tests.  There
} are some Y01completion tests involving files.  A few with more exotic
} characters plus variables wouldn't hurt.  What else is needed?

I agree this would be a good place to start ... exotic characters are
interesting, but probably less so than characters from the set of
pattern characters and other shell specials.


  reply	other threads:[~2016-10-29 20:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  6:12 Georg Nebehay
2016-09-22 14:42 ` Daniel Shahaf
2016-09-22 17:30   ` Bart Schaefer
2016-10-28  1:56     ` Mikael Magnusson
2016-10-28 15:10       ` Daniel Shahaf
2016-10-29 18:06         ` Daniel Shahaf
2016-10-29 18:39           ` Peter Stephenson
2016-10-29 19:44             ` Bart Schaefer [this message]
2016-10-31  3:22             ` Daniel Shahaf
2016-11-27 15:17           ` Daniel Shahaf
2016-11-27 18:30             ` Mikael Magnusson
2016-11-27 18:32               ` Mikael Magnusson
2016-11-27 18:39                 ` Mikael Magnusson
2016-11-28 19:30                   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161029124412.ZM17234@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).