From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2160 invoked by alias); 29 Oct 2016 20:53:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39765 Received: (qmail 19158 invoked from network); 29 Oct 2016 20:53:30 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f169.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.169):SA:0(0.0/5.0):. Processed in 0.853458 secs); 29 Oct 2016 20:53:30 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.169 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=42S4GtSKp66wX7MjzBbbqsASKabFiLfs198VI/nEhnM=; b=YUScbUfEjeal0gzOVcCDGz28Te7lNuDDJgFmkd7OiAIkx9agnYHbLTCnGc7bKUsgru 3lFwHbVZ6rZAR34hbRxxz/iLKeJ6+03M92xr8aNRvJskf3DNqaINVj24SvfYrTc9KOyY RH0DFH1YOi+6mDs0ZYk5poEaTdIYyqvN5xMFrimlLOzM2vRMwwE8d4F31+riI6WjUWIU cmKMulHjZA9IQ3+9EglholcJFu4a8kjhQcZfO/xY/9YzJimpnmTyJPJwJ2s/o77cBGcb ELyhIN97sBZ6sXlfyXgkyQd1Q6lMuNM/OfgHoxGfL7evbwYceEu4hEc99kaljHG2Kt8h FAQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=42S4GtSKp66wX7MjzBbbqsASKabFiLfs198VI/nEhnM=; b=Mchg20e5TyHbSZFBvMGB/5TOxSRePolffwvMJ7/69EAGO4fjGZgkAVO005A3SGYL8h YNw21CNw1NU28n7gGKkXrn3h3KtGMdlH7k7Dl5UF0QlS6HA/bGvSziC1gU9PLV3IuFny 77kLaOsPjtYf6mzV0mUX4Twu8EaiuFGD+yOP+5yB2u9BvvvCxvT/zNT8UjPVUm/gO97i Hx2c6NJ5C8pSsMkuioEMiFZWEZwRJ3+GgEmOY8DaLWnVqQKXZbCdkTCTdeHDzNl4Malp W/XN/ZhKLHhjvspILE/RdC54QZ7oViGoL4QK8Kf5lMkrbHa2TSJeitERvtYU1TpwNGFC TvAg== X-Gm-Message-State: ABUngveO4FgkkU84ShhU1Aw2dm3/ebLuCOBWuexFfobiVuf/jhgHmo2HCIgQ7CIgNf2p2Q== X-Received: by 10.176.82.200 with SMTP id w8mr17666812uaw.62.1477770234450; Sat, 29 Oct 2016 12:43:54 -0700 (PDT) From: Bart Schaefer Message-Id: <161029124412.ZM17234@torch.brasslantern.com> Date: Sat, 29 Oct 2016 12:44:12 -0700 In-Reply-To: <20161029193943.7e2ed791@ntlworld.com> Comments: In reply to Peter Stephenson "Re: Bug: cd auto-completion of .. fails with parentheses in directory name" (Oct 29, 7:39pm) References: <20160922144250.GA11076@fujitsu.shahaf.local2> <160922103042.ZM7407@torch.brasslantern.com> <20161028151037.GA10483@fujitsu.shahaf.local2> <20161029180632.GA18192@fujitsu.shahaf.local2> <20161029193943.7e2ed791@ntlworld.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh workers Subject: Re: Bug: cd auto-completion of .. fails with parentheses in directory name MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Oct 29, 7:39pm, Peter Stephenson wrote: } Subject: Re: Bug: cd auto-completion of .. fails with parentheses in direc } } On Sat, 29 Oct 2016 18:06:32 +0000 } Daniel Shahaf wrote: } > The following fixes it without breaking the original case; however, the } > comment is a Sven original so I'm a bit wary of contravening it. } } That's a "my goodness, is that the time?" if ever I saw it. My intuition would be that the line Daniel commented out was there in the first place because the quoting that was added in the compfiles internals was not previously present. The fact that the end result is double-backslashing of some of the special characters would tend to support this notion. I'd lean toward committing Daniel's _path_files one-line change. } The first step to getting this under control is probably tests. There } are some Y01completion tests involving files. A few with more exotic } characters plus variables wouldn't hurt. What else is needed? I agree this would be a good place to start ... exotic characters are interesting, but probably less so than characters from the set of pattern characters and other shell specials.