From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39819-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 27295 invoked by alias); 3 Nov 2016 13:08:11 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39819
Received: (qmail 8816 invoked from network); 3 Nov 2016 13:08:11 -0000
X-Qmail-Scanner-Diagnostics: from mail-vk0-f50.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.213.50):SA:0(0.0/5.0):. 
 Processed in 0.750093 secs); 03 Nov 2016 13:08:11 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_PASS,T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.50 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version;
        bh=eW7Umr3PoCTtZwbP4ZQUqCm8SSb6IV9bTebTUS9fK7E=;
        b=io3XDd/b3pOs/gNikY1r5StH8RPYMD2V2/xYyKui9vdX74P06JfmWZ3DYRrjU2V0zg
         whthtaUvI3xm1nYC1IPxYKRwDASxmuR7VOeDqblXr8xFZwHr63eO3BVhioHmuO6B53nm
         C66JMjvji5SG/2K2IxBDOd6GE1bgRzU4/RQnWPcP+NYnhF8nMbDoP5ML7NtM6h3Z3o3b
         Ki5IhfulB0k4r/Upf4CFjCnUGAvu5+UgQ+cDuD37WlOTuCqLXtpb1xtLI6HoCb3K6La3
         v3tUrKIxz/qrTrillX1N/vGAcdtOWXUbfRtCQTHbDULlfEj6cJR72yA726lk3XmC1wYv
         FNWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version;
        bh=eW7Umr3PoCTtZwbP4ZQUqCm8SSb6IV9bTebTUS9fK7E=;
        b=lIh2m5xzNek7cDuPYWzxI+Cc0BdstKxN3a3oD7NLzFJggFPifaHkMs+56ZoUKRP8aw
         AxFNR3ayQKYA6CcPHg24VUbRgtEaHEXSGzlsdnSuSH4xeDR3M6QwWYI7TtZgkP2ZISd+
         265HXDXnhLTBdmY8OFjMkp3DlBmxJ5eukW+OUprf/TKYPIbuko40UYHtgxSU9lmasjDN
         n/mmvwlFkjEZOlhEuK+P7q6Q2JsoKQTkEzTglAiCwEFM/f+k6gt58qtkEfx5QaLqSlUo
         rtKhHbtHVqPO2/J33FlE0xbhCmrBHpL41OCilBJRMfUzJbNsLE3WHUFoa1MqJDQk22sN
         m5/g==
X-Gm-Message-State: ABUngvc2TqIbbxCTXS8I30My7y8ZPFqCZaM9jtDKTsJxaUnukU7nZp1+xl05/0BLYdNLdw==
X-Received: by 10.31.57.4 with SMTP id g4mr6240590vka.116.1478178481853;
        Thu, 03 Nov 2016 06:08:01 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <161103060828.ZM14113@torch.brasslantern.com>
Date: Thu, 3 Nov 2016 06:08:28 -0700
In-Reply-To: <37864.1478176981@hydra.kiddle.eu>
Comments: In reply to Oliver Kiddle <okiddle@yahoo.co.uk>
        "Re: Bug in ZSH's vi emulation" (Nov  3,  1:43pm)
References: <20161005080921.GB26647@raspi> 
	<161005101938.ZM12590@torch.brasslantern.com> 
	<20161102045925.GA6763@fujitsu.shahaf.local2> 
	<11719.1478105483@hydra.kiddle.eu> 
	<161102214418.ZM12525@torch.brasslantern.com> 
	<37864.1478176981@hydra.kiddle.eu>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: Bug in ZSH's vi emulation
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Nov 3,  1:43pm, Oliver Kiddle wrote:
}
} That, along with 39813, looks good. As a further tweak, I had to
} make keybuflen not be declared static.

I snuck that into 39813 ...

} It might also be good to
} tweak the comment leading up to this function (startvichange) to
} reference keybuf instead of lastchar.

Indeed.

} Works well in my testing too. We should add a new testcase too such
} as that below.

Shall I commit that or will you?