From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3592 invoked by alias); 8 Nov 2016 22:27:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39879 Received: (qmail 29369 invoked from network); 8 Nov 2016 22:27:58 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk0-f51.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.51):SA:0(0.0/5.0):. Processed in 0.774621 secs); 08 Nov 2016 22:27:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.51 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version:content-transfer-encoding; bh=xw/MIjFnJj/1vHbBO+fDEZmIMuL1vTWR0vbA+pWye7c=; b=cIjUIO/7ilYf1C9LevErQX6Tm02Ogygkc1ICeSvqK6DlAlRcKL/+vVIR3zsQMpS5Ib eSKuSISz26AgatMBG66vvyCoxgxtit2wgby4Z4lAKDceVorDpEobHdsuqIbt/ryvv9vr PuKEQsZkkcLjgYCoLMHTDJ/oguRheV7s/v3DD+H/pZe80+ayS+gHS1fF5E7pYAwxGxqA LVYY/1+OXZ/sxjkS/99clAZf6a+dHp00lmfvYuepF4oDc/NNIvN+lYokCzPhn00iTZbr B/V7VQq9FQ5nF9MuIOxrFu9dQqxwgp9HbEM5sEje9cVLfYTlHWSd9z13RivbsZ8td14z nUjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-transfer-encoding; bh=xw/MIjFnJj/1vHbBO+fDEZmIMuL1vTWR0vbA+pWye7c=; b=fDE1o57NEnVDtuQoDeN5sMVq2y39BCys4wH6f7lusuNpsiOP06KzJ4tiqKOTV+6RpZ OCnweZ0MdrJD6e199ZVctMD1GSb2Edw2EFEZtsnwMnaXbFeBTS/y8U2DbKC7D8NqCla/ HCnMivCrzUmXL0/xizJn0PjUim1Mhz0UjNbM7DRKD2orAYc/9aKA4PygOjEhn7RK7+QF sN/O/Yz9Kv0u3QTVGOqWU9Nc54vXxnTxq0NvQJAHTTLisXSfF0OO7lOKlkX9gAiWB0/C sMQmNsbH2q9frDAr27RDRtK6ZcD9ZYeqE3Fa9QkBJuqwi+wy3fy6X1dKE8qweG2u56GL W5IQ== X-Gm-Message-State: ABUngvel8baOGrK9sVsdL4boeb+9nLAc0PAlQeggIfRipTzJ8rAGgpgwkJ8PDpgRirFyKQ== X-Received: by 10.31.173.86 with SMTP id w83mr2454701vke.58.1478642263279; Tue, 08 Nov 2016 13:57:43 -0800 (PST) From: Bart Schaefer Message-Id: <161108135820.ZM11151@torch.brasslantern.com> Date: Tue, 8 Nov 2016 13:58:20 -0800 In-Reply-To: <1478635899.1897979.781551353.05792438@webmail.messagingengine.com> Comments: In reply to Sebastian Gniazdowski "[PATCH] Optimization of getarrvalue()" (Nov 8, 12:11pm) References: <1478635899.1897979.781551353.05792438@webmail.messagingengine.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] Optimization of getarrvalue() MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable On Nov 8, 12:11pm, Sebastian Gniazdowski wrote: } } More, I suspect a memory leak in following code that has been replaced: }=20 } if (v->end <=3D v->start) } s[0] =3D NULL; } else if (arrlen_ge(s, v->end - v->start)) } s[v->end - v->start] =3D NULL; }=20 } That code adapts array according to end index =E2=80=93=C2=A0however it s= eems that } strings after the NULL are then unreachable to freearray() ? You perhaps haven't noticed that arrdup() uses zhalloc() and dupstring()? Everything is on the heap and is freed by freeheap() or popheap(), never by freearray(). } Interesting that some tests fail (e.g. ./Y03arguments.ztst) if I here } duplicate nular instead of doing: I'm not sure I understand from this exactly what you're describing, but it seems likely to have something to do with confusing zsh heap memory with directly-malloc'd memory.